[skill-drift] update(sentry-react-router-framework-sdk): migrate sendDefaultPii to dataCollection API#161
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…DefaultPii to dataCollection API Automated drift-fix run. Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
| | `sendDefaultPii` | `boolean` | `false` | Includes headers/IP-derived user context | | ||
| | `dataCollection` | `object` | — | Controls what data is collected (userInfo, cookies, httpHeaders, etc.) | | ||
| | `dataCollection.userInfo` | `boolean` | `false` | Includes IP-derived user context | | ||
| | `dataCollection.cookies` | `CollectBehavior` | `true` | Controls cookie collection and filtering | |
There was a problem hiding this comment.
Bug: The documentation for dataCollection.cookies incorrectly states its default is true, while the actual SDK default is false.
Severity: MEDIUM
Suggested Fix
Update the documentation table in SKILL.md to change the default value for dataCollection.cookies from true to false. This will align the documentation with the actual behavior of the Sentry JavaScript SDK.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-react-router-framework-sdk/SKILL.md#L306
Potential issue: The documentation for the `dataCollection.cookies` option incorrectly
states that its default value is `true`. The actual default behavior of the Sentry
JavaScript SDK is `false`, meaning cookie collection is disabled unless explicitly
enabled. This documentation error can mislead developers about Personally Identifiable
Information (PII) collection, causing them to have incorrect privacy assumptions or
misconfigure their Sentry setup. Authoritative Sentry documentation confirms that the
SDK does not send cookies by default.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
Summary
The Sentry JavaScript SDK deprecated
sendDefaultPiiin favor of the newdataCollectionAPI (PR #21277, merged 2026-06-02). This updates the React Router Framework skill to use the current recommended configuration.Changes
sendDefaultPii: truewithdataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } }sendDefaultPii: truewithdataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } }dataCollectionoptions and markedsendDefaultPiias deprecated (removed in v11)Context
From PR #21277:
The new
dataCollectionAPI provides granular control over what data is collected: userInfo, cookies, httpHeaders, httpBodies, queryParams, genAI inputs/outputs, stackFrameVariables, and frameContextLines.Verification
The skill examples remain functionally equivalent —
dataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } }captures the same data as the deprecatedsendDefaultPii: truefor typical use cases.Source PRs
sendDefaultPiiin favor ordataCollection