Skip to content

[skill-drift] update(sentry-react-router-framework-sdk): migrate sendDefaultPii to dataCollection API#161

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
skill-drift/sentry-react-router-framework-sdk-skill-drift-update-sentry-react-router-f-1780927696
Open

[skill-drift] update(sentry-react-router-framework-sdk): migrate sendDefaultPii to dataCollection API#161
github-actions[bot] wants to merge 1 commit into
mainfrom
skill-drift/sentry-react-router-framework-sdk-skill-drift-update-sentry-react-router-f-1780927696

Conversation

@github-actions

@github-actions github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Auto-generated from external SDK content. Review all links and code suggestions before acting on them.

Summary

The Sentry JavaScript SDK deprecated sendDefaultPii in favor of the new dataCollection API (PR #21277, merged 2026-06-02). This updates the React Router Framework skill to use the current recommended configuration.

Changes

  • Client init example: Replaced sendDefaultPii: true with dataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } }
  • Server init example: Replaced sendDefaultPii: true with dataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } }
  • Configuration reference table: Added dataCollection options and marked sendDefaultPii as deprecated (removed in v11)

Context

From PR #21277:

sendDefaultPii will be removed in the next major version (v11). For backwards compatibility, setting sendDefaultPii: true currently behaves like enabling all dataCollection categories. If both are set, sendDefaultPii will be ignored.

The new dataCollection API provides granular control over what data is collected: userInfo, cookies, httpHeaders, httpBodies, queryParams, genAI inputs/outputs, stackFrameVariables, and frameContextLines.

Verification

The skill examples remain functionally equivalent — dataCollection: { userInfo: true, cookies: true, httpHeaders: { request: true, response: true } } captures the same data as the deprecated sendDefaultPii: true for typical use cases.

Source PRs

…DefaultPii to dataCollection API

Automated drift-fix run.

Co-Authored-By: Claude (claude-sonnet-4-5) <noreply@anthropic.com>
| `sendDefaultPii` | `boolean` | `false` | Includes headers/IP-derived user context |
| `dataCollection` | `object` | — | Controls what data is collected (userInfo, cookies, httpHeaders, etc.) |
| `dataCollection.userInfo` | `boolean` | `false` | Includes IP-derived user context |
| `dataCollection.cookies` | `CollectBehavior` | `true` | Controls cookie collection and filtering |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The documentation for dataCollection.cookies incorrectly states its default is true, while the actual SDK default is false.
Severity: MEDIUM

Suggested Fix

Update the documentation table in SKILL.md to change the default value for dataCollection.cookies from true to false. This will align the documentation with the actual behavior of the Sentry JavaScript SDK.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: skills/sentry-react-router-framework-sdk/SKILL.md#L306

Potential issue: The documentation for the `dataCollection.cookies` option incorrectly
states that its default value is `true`. The actual default behavior of the Sentry
JavaScript SDK is `false`, meaning cookie collection is disabled unless explicitly
enabled. This documentation error can mislead developers about Personally Identifiable
Information (PII) collection, causing them to have incorrect privacy assumptions or
misconfigure their Sentry setup. Authoritative Sentry documentation confirms that the
SDK does not send cookies by default.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants