-
-
Notifications
You must be signed in to change notification settings - Fork 229
chore: Use SLNX format for solution files #4911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
| var assembly = typeof(AttributeReaderTests).Assembly; | ||
| Assert.NotNull(AttributeReader.TryGetProjectDirectory(assembly)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: test without assertion
Intended?
Should we run test in Release mode, could typeof(AttributeReaderTests).Assembly be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worryingly, the dotnet format tool did this, according to the commit history!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4911 +/- ##
==========================================
- Coverage 73.88% 73.86% -0.02%
==========================================
Files 494 494
Lines 17868 17868
Branches 3509 3509
==========================================
- Hits 13202 13199 -3
- Misses 3807 3809 +2
- Partials 859 860 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This reverts commit 7a0cec0.
7fe6759 to
704d35f
Compare
Resolves #4040:
#skip-changelog