Skip to content

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver self-assigned this Jan 21, 2026
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.54%. Comparing base (9895de7) to head (e0e309e).
⚠️ Report is 3 commits behind head on support/v5.

Additional details and impacted files
@@              Coverage Diff               @@
##           support/v5    #4855      +/-   ##
==============================================
+ Coverage       73.50%   73.54%   +0.03%     
==============================================
  Files             483      483              
  Lines           17692    17692              
  Branches         3492     3492              
==============================================
+ Hits            13005    13011       +6     
+ Misses           3796     3793       -3     
+ Partials          891      888       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flash0ver Flash0ver marked this pull request as ready for review January 22, 2026 13:29
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

{
base.OnCreate(savedInstanceState);

System.Environment.SetEnvironmentVariable("SENTRY_DSN", Intent?.GetStringExtra("SENTRY_DSN"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused runtime DSN on Android is dead code

Low Severity

The SENTRY_DSN environment variable is set in MainActivity.OnCreate() from intent extras, and RunAndroidApp passes the DSN via intent. However, this value is never used because the Sentry SDK is already configured with a hardcoded DSN in MauiProgram.cs (which runs before OnCreate()). For Android, options.Dsn is explicitly set at build time, so the environment variable fallback never triggers. This dead code creates confusion about how DSN configuration works on Android versus iOS.

Additional Locations (1)

Fix in Cursor Fix in Web

@Flash0ver Flash0ver merged commit ccff918 into support/v5 Jan 23, 2026
31 of 32 checks passed
@Flash0ver Flash0ver deleted the support/v5-backport-4666 branch January 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants