-
-
Notifications
You must be signed in to change notification settings - Fork 229
chore(deps): update Java SDK to v8.32.0 #4843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d598fdc to
3b98c9e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4843 +/- ##
==========================================
+ Coverage 73.86% 73.88% +0.01%
==========================================
Files 494 494
Lines 17868 17868
Branches 3509 3509
==========================================
+ Hits 13199 13202 +3
+ Misses 3809 3807 -2
+ Partials 860 859 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b39ecba to
4160a34
Compare
948758b to
0bac229
Compare
7d7b339 to
4e5880c
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
🤖 This preview updates automatically when you update the PR. |
dba5b42 to
0f9d2d7
Compare
|
Problem The nearest available Proposal Claude proposes the following: <ItemGroup>
<AndroidMavenLibrary Include="com.google.protobuf:protobuf-javalite" Version="3.25.8" Bind="false" />
</ItemGroup>Does it sound like the correct thing to do? Related Java SDK changes:
|
0f9d2d7 to
d4e6b67
Compare
Possibly... as long as we don't have another (conflicting) version as a transient dependency via one of our NuGets. That would typically occur as an indirect result of having |
d4e6b67 to
976c91e
Compare
976c91e to
881ae9e
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| <!-- protobuf-javalite 3.25.8 has no matching/compatible Xamarin.Protobuf.JavaLite NuGet package | ||
| (see https://github.com/getsentry/sentry-java/pull/5044) --> | ||
| <ItemGroup> | ||
| <AndroidMavenLibrary Include="com.google.protobuf:protobuf-javalite" Version="3.25.8" Bind="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add mention of this in the changelog (the fact that we're adding a new dependency when targeting net10.0-android).
I think a changelog would get generated automatically for this PR now that we've moved to automated changelogs. However, OOTB it would use the title of the PR, which doesn't make any mention of this new dependency.
Apparently it's possible to customise the changelog for a PR though:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :) I've added changelog entries to the PR description
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment re documenting the new dependency in the changelog. Otherwise looks awesome - thanks @jpnurmi !
Bumps scripts/update-java.ps1 from 8.29.0 to 8.32.0.
Auto-generated by a dependency updater.
Changelog
8.32.0
Features
installGroupsOverrideparameter andinstallGroupsproperty to Build Distribution SDK (#5062)io.sentry.spotlight.enableandio.sentry.spotlight.url(#5064)BEGIN,COMMIT,ROLLBACK) (#5072)options.enableDatabaseTransactionTracingtotrueenable-database-transaction-tracing=truewhen usingsentry.propertiessentry.enable-database-transaction-tracing=trueinapplication.propertiesor inapplication.yml:ApplicationExitInfo.REASON_CRASH_NATIVEon Android 12+AndroidManifest.xmlusing:Fixes
SpotlightIntegrationto separatesentry-spotlightmodule to prevent insecure HTTP URLs from appearing in release APKs (#5064)io.sentry:sentry-spotlightdependency:dependencies { debugImplementation("io.sentry:sentry-spotlight:<version>") }Scopesforreactor-kafkaconsumer pollRunnable(#5080)reactor-kafka's poll event reschedules itself infinitely, and each invocation ofSentryScheduleHookcreated forked scopes with a parent reference, building an unbounded chain that couldn't be garbage collected.Internal
sentry-nativefromApplicationExitInfo. (#5052)writepermission forstatusesin the changelog preview GHA workflow. (#5053)Dependencies
8.31.0
Features
io.sentry.ndk.sdk-nameAndroid manifest option to configure the native SDK's name (#5027)sentry.trace.parent_span_idattribute withspanIdproperty onSentryLogEvent(#5040)Fixes
sendDefaultPiiis enabled (#5036)LoggerBatchProcessoris shutting down (#5041)Dependencies
8.30.0
Fixes
use
options.isCollectExternalStorageContext = trueor<meta-data android:name="io.sentry.external-storage-context" android:value="true" />NullPointerExceptionwhen reading ANR marker (#4979)log_byte(#4971)Improvements
MAX_EVENT_SIZE_BYTESconstant in SentryOptions (#4962)4xxand5xxresponse (#4950)Feature
ApplicationExitInfo.REASON_CRASH_NATIVEon Android 12+. (#4933)Sentry.metrics()count: A metric that increments countsgauge: A metric that tracks a value that can go up or downdistribution: A metric that tracks the statistical distribution of valuesChangelog Entry
protobuf-javalite3.25.8 dependency on Android