-
-
Notifications
You must be signed in to change notification settings - Fork 230
chore(deps): update Cocoa SDK to v9.2.0 #4781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4ff6050
chore: update modules/sentry-cocoa.properties to 9.2.0
web-flow 8a6509a
Update bindings for Cocoa SDK v9 (#4830)
jpnurmi 015dd80
Bump iOS SupportedOSPlatformVersion from 13.0 to 15.0
jpnurmi 31e7f07
scripts/patch-cocoa-bindings.cs: remove old unused SentryMechanismMeta
jpnurmi 87249e6
scripts/patch-cocoa-bindings.cs: clean up SwiftExperimentalOptions
jpnurmi 8d3129f
Merge remote-tracking branch 'upstream/main' into deps/modules/sentry…
jpnurmi 159bedb
Remove updater's old changelog entry
jpnurmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| version = 8.57.3 | ||
| version = 9.2.0 | ||
| repo = https://github.com/getsentry/sentry-cocoa | ||
|
jamescrosswell marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
sentry[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: breaking change?
Just to be sure ... now that I actually write it down I don't think there is a breaking change for .NET MAUI 9 or .NET MAUI 10 consumers, but just to be sure:
In this
Directory.Build.props, we declare:sentry-dotnet/Directory.Build.props
Lines 33 to 36 in 87249e6
In the .NET MAUI SDK
Sentry.Maui, we then use:sentry-dotnet/src/Sentry.Maui/Sentry.Maui.csproj
Lines 9 to 13 in 87249e6
Just to make sure:
Our in this changeset unchanged iOS and Mac Catalyst version is
18.0for .NET 9 (and26.0for .NET 10),and now bumping
sentry-cocoato9.2.0, where9.0.0noteswe are not introducing any breaking changes, are we?
Also considering the related conversation from the preceding changeset of
And also considering the Supported platforms for .NET MAUI apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from #4781 (comment), on which I'll follow up on Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means anyone using the apps developed by Sentry SDK customers would need to upgrades from iOS 13 to 15 in order to be able to continue to use those apps... so it's not breaking for our SDK users and it's just part of the normal phasing out of old platforms for Apple.