-
-
Notifications
You must be signed in to change notification settings - Fork 229
chore: Device/integration tests for mobile on .net10 #4750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d2c4358
5e9fdcb
f99a711
5b7fbc3
d40c030
344c80a
b8d6c02
241a908
a773aa5
278c04c
ad9c671
429801b
cf16076
0889735
c1b3e7c
0adaddb
1361614
ed8b558
7674108
5fdc832
5d27b34
cce63e9
3f5f227
2f798fd
00c6767
461ff9b
03cdd74
c8d7051
91da55f
130e51a
1309078
b38c497
edcc792
68db72f
3b5ea8d
4580fe2
7f66cda
af39bb7
8ce560c
30cd0f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,8 +12,11 @@ BeforeDiscovery { | |
| } | ||
|
|
||
| Describe 'iOS app (<tfm>, <configuration>)' -ForEach @( | ||
| @{ tfm = "net9.0-ios18.0"; configuration = "Release" } | ||
| @{ tfm = "net9.0-ios18.0"; configuration = "Debug" } | ||
| # Note: we can't run against net10 and net9 becaus .NET 10 requires Xcode 26.2 and .NET 9 requires Xcode 26.0. | ||
| # The macOS GitHub Actions runners only have Xcode 26.1+ installed and no support for Xcode 26.2 is planned for | ||
| # net9.0-ios: https://github.com/dotnet/macios/issues/24199#issuecomment-3819021247 | ||
|
Comment on lines
+15
to
+17
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. follow-up: #4895 |
||
| @{ tfm = "net10.0-ios26.2"; configuration = "Release" } | ||
| @{ tfm = "net10.0-ios26.2"; configuration = "Debug" } | ||
| ) -Skip:(-not $script:simulator) { | ||
| BeforeAll { | ||
| . $PSScriptRoot/../scripts/device-test-utils.ps1 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(TargetFrameworks);net9.0-android35.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net9.0-ios18.0</TargetFrameworks> | ||
| <TargetFrameworks>$(TargetFrameworks);net9.0-android35.0;net10.0-android36.0</TargetFrameworks> | ||
| <!-- Pin target iOS version so that our tests don't break when new versions of Xcode are released. | ||
| 'netX.0-ios' resolves the latest version of the iOS SDK otherwise. | ||
| --> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net10.0-ios26.2</TargetFrameworks> | ||
|
Comment on lines
+5
to
+8
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. follow-up: #4895 |
||
|
|
||
| <OutputType>Exe</OutputType> | ||
| <RootNamespace>Sentry.Maui.Device.IntegrationTestApp</RootNamespace> | ||
|
|
@@ -31,7 +34,7 @@ | |
|
|
||
| <SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">15.0</SupportedOSPlatformVersion> | ||
| <SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">21.0</SupportedOSPlatformVersion> | ||
| <TargetPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">18.0</TargetPlatformVersion> | ||
|
|
||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(TargetFrameworks);net9.0-android</TargetFrameworks> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net9.0-ios</TargetFrameworks> | ||
| <TargetFrameworks>$(TargetFrameworks);net9.0-android;net10.0-android</TargetFrameworks> | ||
| <!-- Note: we can't run against net9-ios because .NET 10 requires Xcode 26.2 and .NET 9 requires Xcode 26.0. | ||
| The macOS GitHub Actions runners only have Xcode 26.1+ installed and no support for Xcode 26.2 is planned for | ||
| net9.0-ios: https://github.com/dotnet/macios/issues/24199#issuecomment-3819021247 | ||
| --> | ||
| <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('OSX'))">$(TargetFrameworks);net10.0-ios</TargetFrameworks> | ||
|
Comment on lines
+5
to
+9
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. follow-up: #4895 |
||
| <DefineConstants Condition="'$(EnableMauiDeviceTestVisualRunner)' == 'true'">$(DefineConstants);VISUAL_RUNNER</DefineConstants> | ||
| </PropertyGroup> | ||
|
|
||
|
|
@@ -34,8 +38,7 @@ | |
| <SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">21.0</SupportedOSPlatformVersion> | ||
| <!-- Pin target iOS version so that our tests don't break when new versions of Xcode are released. | ||
| 'netX.0-ios' resolves the latest version of the iOS SDK otherwise. --> | ||
| <TargetPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">18.0</TargetPlatformVersion> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could leave this in there (bump to 26.2 of course)... that would be consistent with what we've done for the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. follow-up: #4895 |
||
|
|
||
| <TargetPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'">26.2</TargetPlatformVersion> | ||
| <EmbedAssembliesIntoApk>true</EmbedAssembliesIntoApk> | ||
|
|
||
| <!-- Avoid errors of Sentry.Testing not being a self-contained executable, while including it in a self-contained executable (this). | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.