Skip to content

Add ci workflow for app size analysis #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
buenaflor wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add ci workflow for app size analysis #3368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ef39693
feat: Add Sentry size analysis GitHub workflow
cursoragent Nov 25, 2025
8425109
Update
buenaflor Nov 25, 2025
83b9a61
Update
buenaflor Nov 25, 2025
e3a5a47
Update
buenaflor Nov 26, 2025
b7ef080
Update
buenaflor Nov 26, 2025
9872f07
Change APK build step to Appbundle in workflow
buenaflor Nov 26, 2025
ac4fd03
Rename upload step for Android bundle in workflow
buenaflor Nov 26, 2025
9b0ab2f
Update
buenaflor Nov 27, 2025
806dd0b
Update
buenaflor Nov 28, 2025
1b45278
Update
buenaflor Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 212 additions & 0 deletions .github/workflows/size-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,212 @@
name: Size Analysis

on:
push:
branches:
- main
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

env:
SENTRY_ORG: sentry-sdks
SENTRY_PROJECT: sentry-flutter
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}

jobs:
android:
name: Android
runs-on: ubuntu-latest
timeout-minutes: 30
defaults:
run:
working-directory: packages/flutter/example

steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0

- uses: actions/setup-java@v5
with:
distribution: 'adopt'
java-version: '17'

- name: Read configured Flutter SDK version
id: conf
run: |
version=$(grep "version" ../../../metrics/flutter.properties | cut -d'=' -f2 | xargs)
echo "flutter=$version" >> "$GITHUB_OUTPUT"
- name: Install Flutter v${{ steps.conf.outputs.flutter }}
uses: subosito/flutter-action@fd55f4c5af5b953cc57a2be44cb082c8f6635e8e # pin@v2.21.0
with:
flutter-version: ${{ steps.conf.outputs.flutter }}

- name: Install Sentry CLI
if: env.SENTRY_AUTH_TOKEN != ''
run: curl -sL https://sentry.io/get-cli/ | SENTRY_CLI_VERSION=2.58.2 sh

- name: Determine build version
run: |
version_line=$(grep '^version:' pubspec.yaml | awk '{print $2}')
# Remove any + suffix first (for pubspec.yaml versions like 1.2.3+4)
version=${version_line%%+*}
# Parse version: x.y.z-suffix.n → build_name=x.y.z, build_number=n
# Supports: x.y.z, x.y.z-alpha.n, x.y.z-beta.n, x.y.z-rc.n, etc.
# Note: build_name is x.y.z only (plist/Android compatibility)
if [[ $version =~ ^([0-9]+\.[0-9]+\.[0-9]+)-[a-zA-Z]+\.([0-9]+)$ ]]; then
build_name="${BASH_REMATCH[1]}"
build_number="${BASH_REMATCH[2]}"
elif [[ $version =~ ^([0-9]+\.[0-9]+\.[0-9]+)$ ]]; then
build_name="${BASH_REMATCH[1]}"
build_number=1
else
build_name="$version"
build_number=1
fi
echo "SIZE_VERSION=$build_name" >> "$GITHUB_ENV"
echo "SIZE_BUILD=$build_number" >> "$GITHUB_ENV"
- name: Get merge base SHA
id: merge-base
if: env.SENTRY_AUTH_TOKEN != ''
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
BASE_SHA="${{ github.event.pull_request.base.sha }}"
else
BASE_SHA=$(git merge-base HEAD origin/main || echo "${{ github.event.before }}")
fi
echo "sha=$BASE_SHA" >> "$GITHUB_OUTPUT"
- name: Build Android Appbundle
run: |
flutter pub get
flutter build appbundle --release \
--build-name "$SIZE_VERSION" \
--build-number "$SIZE_BUILD"
- name: Upload Android Bundle to Sentry Size Analysis
if: env.SENTRY_AUTH_TOKEN != ''
run: |
UPLOAD_ARGS=(
"build/app/outputs/bundle/release/app-release.aab"
"--org" "${{ env.SENTRY_ORG }}"
"--project" "${{ env.SENTRY_PROJECT }}"
"--build-configuration" "Release"
"--head-sha" "${{ github.event.pull_request.head.sha || github.sha }}"
Copy link

@runningcode runningcode Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't need to set head-sha, head-repo-name, head-ref, base-ref, base-sha or pr-number in github actions as they will be automatically fetched. were you having issue with this? I'd love to debug if it wasn't working.

Copy link
Contributor Author

@buenaflor buenaflor Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tried without tbh, this is mostly cursor code :D

I'll remove it and re-run

"--head-repo-name" "${{ github.repository }}"
"--head-ref" "${{ github.head_ref || github.ref_name }}"
"--base-ref" "${{ github.base_ref || 'main' }}"
)
if [ -n "${{ steps.merge-base.outputs.sha }}" ]; then
UPLOAD_ARGS+=("--base-sha" "${{ steps.merge-base.outputs.sha }}")
fi
if [ -n "${{ github.event.pull_request.number }}" ]; then
UPLOAD_ARGS+=("--pr-number" "${{ github.event.pull_request.number }}")
fi
sentry-cli build upload "${UPLOAD_ARGS[@]}"
ios:
name: iOS
runs-on: macos-15
timeout-minutes: 45
defaults:
run:
working-directory: packages/flutter/example

steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Read configured Flutter SDK version
id: conf
run: |
version=$(grep "version" ../../../metrics/flutter.properties | cut -d'=' -f2 | xargs)
echo "flutter=$version" >> "$GITHUB_OUTPUT"
- name: Install Flutter v${{ steps.conf.outputs.flutter }}
uses: subosito/flutter-action@fd55f4c5af5b953cc57a2be44cb082c8f6635e8e # pin@v2.21.0
with:
flutter-version: ${{ steps.conf.outputs.flutter }}

- name: Install Sentry CLI
if: env.SENTRY_AUTH_TOKEN != ''
run: curl -sL https://sentry.io/get-cli/ | SENTRY_CLI_VERSION=2.58.2 sh

- name: Determine build version
run: |
version_line=$(grep '^version:' pubspec.yaml | awk '{print $2}')
# Remove any + suffix first (for pubspec.yaml versions like 1.2.3+4)
version=${version_line%%+*}
# Parse version: x.y.z-suffix.n → build_name=x.y.z, build_number=n
# Supports: x.y.z, x.y.z-alpha.n, x.y.z-beta.n, x.y.z-rc.n, etc.
# Note: build_name is x.y.z only (plist/Android compatibility)
if [[ $version =~ ^([0-9]+\.[0-9]+\.[0-9]+)-[a-zA-Z]+\.([0-9]+)$ ]]; then
build_name="${BASH_REMATCH[1]}"
build_number="${BASH_REMATCH[2]}"
elif [[ $version =~ ^([0-9]+\.[0-9]+\.[0-9]+)$ ]]; then
build_name="${BASH_REMATCH[1]}"
build_number=1
else
build_name="$version"
build_number=1
fi
echo "SIZE_VERSION=$build_name" >> "$GITHUB_ENV"
echo "SIZE_BUILD=$build_number" >> "$GITHUB_ENV"
# QuickFix for failing iOS 18.0 builds https://github.com/actions/runner-images/issues/12758#issuecomment-3187115656
- name: Switch to Xcode 16.4 for iOS 18.5
run: sudo xcode-select --switch /Applications/Xcode_16.4.app

- name: Build Flutter iOS
run: |
flutter pub get
flutter build ipa --release --no-codesign \
--build-name "$SIZE_VERSION" \
--build-number "$SIZE_BUILD"
- name: Get merge base SHA
id: merge-base
if: env.SENTRY_AUTH_TOKEN != ''
run: |
if [ "${{ github.event_name }}" == "pull_request" ]; then
BASE_SHA="${{ github.event.pull_request.base.sha }}"
else
BASE_SHA=$(git merge-base HEAD origin/main || echo "${{ github.event.before }}")
fi
echo "sha=$BASE_SHA" >> "$GITHUB_OUTPUT"
- name: Upload iOS XCArchive to Sentry Size Analysis
if: env.SENTRY_AUTH_TOKEN != ''
run: |
UPLOAD_ARGS=(
"build/ios/archive/Runner.xcarchive"
"--org" "${{ env.SENTRY_ORG }}"
"--project" "${{ env.SENTRY_PROJECT }}"
"--build-configuration" "Release"
"--head-sha" "${{ github.event.pull_request.head.sha || github.sha }}"
Copy link

@runningcode runningcode Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for android. let's debug this.

"--head-repo-name" "${{ github.repository }}"
"--head-ref" "${{ github.head_ref || github.ref_name }}"
"--base-ref" "${{ github.base_ref || 'main' }}"
)
if [ -n "${{ steps.merge-base.outputs.sha }}" ]; then
UPLOAD_ARGS+=("--base-sha" "${{ steps.merge-base.outputs.sha }}")
fi
if [ -n "${{ github.event.pull_request.number }}" ]; then
UPLOAD_ARGS+=("--pr-number" "${{ github.event.pull_request.number }}")
fi
sentry-cli build upload "${UPLOAD_ARGS[@]}"
4 changes: 2 additions & 2 deletions packages/flutter/example/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (flutterVersionName == null) {
}

android {
namespace = "io.sentry.samples.flutter"
namespace = "io.sentry.flutter.sample"
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Expand All @@ -44,7 +44,7 @@ android {
}

defaultConfig {
applicationId "io.sentry.samples.flutter"
applicationId "io.sentry.flutter.sample"
minSdkVersion flutter.minSdkVersion
targetSdkVersion 35
versionCode flutterVersionCode.toInteger()
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter/example/android/app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
-keep class io.sentry.samples.flutter.** { *; }
-keep class io.sentry.flutter.sample.** { *; }
2 changes: 1 addition & 1 deletion packages/flutter/example/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.sentry.samples.flutter">
package="io.sentry.flutter.sample">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
Expand Down
2 changes: 1 addition & 1 deletion ...ges/flutter/example/android/app/src/main/kotlin/io/sentry/samples/flutter/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.sentry.samples.flutter
package io.sentry.flutter.sample
Copy link

@sentry sentry bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: MainActivity.kt package declaration io.sentry.flutter.sample mismatches its directory io/sentry/samples/flutter/.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The MainActivity.kt file's package declaration io.sentry.flutter.sample does not match its physical directory structure io/sentry/samples/flutter/. This fundamental mismatch will cause the Kotlin compiler to reject the code, leading to an immediate failure of the Android build step in the CI workflow. This prevents the successful creation of the Android AAB artifact.

💡 Suggested Fix

Either move MainActivity.kt to io/sentry/flutter/sample/ or revert its package declaration to io.sentry.samples.flutter.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
packages/flutter/example/android/app/src/main/kotlin/io/sentry/samples/flutter/MainActivity.kt#L1

Potential issue: The `MainActivity.kt` file's package declaration
`io.sentry.flutter.sample` does not match its physical directory structure
`io/sentry/samples/flutter/`. This fundamental mismatch will cause the Kotlin compiler
to reject the code, leading to an immediate failure of the Android build step in the CI
workflow. This prevents the successful creation of the Android AAB artifact.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4268466

Copy link

@runningcode runningcode Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is real

Copy link
Contributor Author

@buenaflor buenaflor Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, haven't gotten to fixing this yet


import android.os.Handler
import io.flutter.embedding.android.FlutterActivity
Expand Down
4 changes: 1 addition & 3 deletions packages/flutter/example/integration_test/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,9 +362,7 @@ void main() {
final contexts = await SentryFlutter.native?.loadContexts();

final appPackageInfo = await PackageInfo.fromPlatform();
final expectedAppId = Platform.isAndroid
? 'io.sentry.samples.flutter'
: 'io.sentry.flutter.sample';
const expectedAppId = 'io.sentry.flutter.sample';
final expectedSdkName =
Platform.isAndroid ? 'maven:sentry-android' : 'cocoapods:sentry-cocoa';
final expectedVersion = appPackageInfo.version;
Expand Down
6 changes: 3 additions & 3 deletions packages/flutter/test/android_platform_exception_event_processor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,9 @@ const _jvmStackTrace =
at io.flutter.plugin.common.StandardMessageCodec.writeValue(StandardMessageCodec.java:292)
at io.flutter.plugin.common.StandardMethodCodec.encodeSuccessEnvelope(StandardMethodCodec.java:59)
at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler\$1.success(MethodChannel.java:267)
at io.sentry.samples.flutter.MainActivity.configureFlutterEngine\$lambda-0(MainActivity.kt:40)
at io.sentry.samples.flutter.MainActivity.lambda\$TiSaAm1LIEmKLVswI4BlR_5sw5Y(Unknown Source:0)
at io.sentry.samples.flutter.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)
at io.sentry.flutter.sample.MainActivity.configureFlutterEngine\$lambda-0(MainActivity.kt:40)
at io.sentry.flutter.sample.MainActivity.lambda\$TiSaAm1LIEmKLVswI4BlR_5sw5Y(Unknown Source:0)
Copy link

@sentry sentry bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Old package ID io.sentry.samples.flutter remains in AppFrameworkInfo.plist and run.sh.
Severity: HIGH | Confidence: High

🔍 Detailed Analysis

The old package ID io.sentry.samples.flutter is still referenced in packages/flutter/example/ios/Flutter/AppFrameworkInfo.plist and packages/flutter/example/run.sh. This indicates an incomplete update of the package ID across the project, which could lead to build failures or incorrect application behavior on iOS and during script execution.

💡 Suggested Fix

Update all remaining references of io.sentry.samples.flutter to the new package ID io.sentry.flutter.sample in AppFrameworkInfo.plist and run.sh.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
packages/flutter/test/android_platform_exception_event_processor_test.dart#L247

Potential issue: The old package ID `io.sentry.samples.flutter` is still referenced in
`packages/flutter/example/ios/Flutter/AppFrameworkInfo.plist` and
`packages/flutter/example/run.sh`. This indicates an incomplete update of the package ID
across the project, which could lead to build failures or incorrect application behavior
on iOS and during script execution.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 4268466

at io.sentry.flutter.sample.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)
at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler.onMessage(MethodChannel.java:262)
at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:296)
at io.flutter.embedding.engine.dart.DartMessenger.lambda\$dispatchMessageToQueue\$0\$DartMessenger(DartMessenger.java:320)
Expand Down
8 changes: 4 additions & 4 deletions packages/flutter/test/jvm/jvm_exception_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ java.lang.IllegalArgumentException: Unsupported value: '[Ljava.lang.StackTraceEl
at io.flutter.plugin.common.StandardMessageCodec.writeValue(StandardMessageCodec.java:292)
at io.flutter.plugin.common.StandardMethodCodec.encodeSuccessEnvelope(StandardMethodCodec.java:59)
at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler\$1.success(MethodChannel.java:267)
at io.sentry.samples.flutter.MainActivity.configureFlutterEngine\$lambda-0(MainActivity.kt:40)
at io.sentry.samples.flutter.MainActivity.lambda\$TiSaAm1LIEmKLVswI4BlR_5sw5Y(Unknown Source:0)
at io.sentry.samples.flutter.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)
at io.sentry.flutter.sample.MainActivity.configureFlutterEngine\$lambda-0(MainActivity.kt:40)
at io.sentry.flutter.sample.MainActivity.lambda\$TiSaAm1LIEmKLVswI4BlR_5sw5Y(Unknown Source:0)
at io.sentry.flutter.sample.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)
at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler.onMessage(MethodChannel.java:262)
at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:296)
at io.flutter.embedding.engine.dart.DartMessenger.lambda\$dispatchMessageToQueue\$0\$DartMessenger(DartMessenger.java:320)
Expand Down Expand Up @@ -248,7 +248,7 @@ android.content.res.Resources\$NotFoundException: Unable to find resource ID #0x

const platformExceptionWithEmptyStackFrames = '''
java.lang.RuntimeException: Catch this platform exception!
at io.sentry.samples.flutter.MainActivity\$configureFlutterEngine\$1.onMethodCall(MainActivity.kt:40)
at io.sentry.flutter.sample.MainActivity\$configureFlutterEngine\$1.onMethodCall(MainActivity.kt:40)
at io.flutter.plugin.common.MethodChannel\$IncomingMethodCallHandler.onMessage(MethodChannel.java:258)
at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
at io.flutter.embedding.engine.dart.DartMessenger.lambda\$dispatchMessageToQueue\$0\$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:322)
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter/test/jvm/jvm_frame_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ void main() {

test('parses frame with lambda and unknown source', () {
final frame = JvmFrame.parse(
'at io.sentry.samples.flutter.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)',
'at io.sentry.flutter.sample.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y.onMethodCall(Unknown Source:2)',
);
expect(frame.fileName, 'Unknown Source');
expect(frame.lineNumber, 2);
expect(frame.method, 'onMethodCall');
expect(
frame.className,
'io.sentry.samples.flutter.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y',
'io.sentry.flutter.sample.-\$\$Lambda\$MainActivity\$TiSaAm1LIEmKLVswI4BlR_5sw5Y',
);
expect(frame.skippedFrames, null);
expect(frame.isNativeMethod, false);
Expand Down
Loading