fix(api): Retry API requests on DNS resolution failure #3085
+67
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dns
branch
from
e5f8b7e to
e6938fe
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dns
branch
2 times, most recently
from
4ea812a to
63df8e7
Compare
When DNS resolution fails (CURLE_COULDNT_RESOLVE_HOST), the CLI now retries the request using the existing exponential backoff retry mechanism. This addresses intermittent DNS failures that were causing ~5-10% of builds to fail. Fixes #2763 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/dns
branch
from
571dd03 to
99c690c
Compare
loewenheim
reviewed
Feb 9, 2026
Comment on lines
+17
to
25
| pub(super) enum RetryError { | ||
| #[error("request failed with retryable status code {}", body.status)] | ||
| Status { body: ApiResponse }, | ||
| #[error("request failed with retryable error: {source}")] | ||
| ApiError { | ||
| #[from] | ||
| source: ApiError, | ||
| }, | ||
| } |
Contributor
There was a problem hiding this comment.
It reads weirdly to me that an ApiError is a kind of RetryError—if anything, I would expect the inverse. I would suggest slightly renaming this.
Suggested change
| pub(super) enum RetryError { | |
| #[error("request failed with retryable status code {}", body.status)] | |
| Status { body: ApiResponse }, | |
| #[error("request failed with retryable error: {source}")] | |
| ApiError { | |
| #[from] | |
| source: ApiError, | |
| }, | |
| } | |
| pub(super) enum RequestError { | |
| #[error("request failed with retryable status code {}", body.status)] | |
| Retry { body: ApiResponse }, | |
| #[error(transparent)] | |
| ApiError { | |
| #[from] | |
| source: ApiError, | |
| }, | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sentry CLI now retries requests that fail to resolve
sentry.io, addressing intermittent failures for some users uploading symbol files. Retries are limited tosentry.iohosts to avoid masking configuration issues for other domains.Issues