forked from rrweb-io/rrweb
-
Notifications
You must be signed in to change notification settings - Fork 11
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c886733
build: Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4
chargome 8a946d9
fix(test): Fix test compatibility with vitest 2
chargome 2512a4e
ci: Fix CI for vite 6 upgrade
chargome 348b425
fix(build): Address review findings from vite/vitest bump
chargome 79f2b0d
fix(build): Restore prepack script in rrvideo
chargome 426b9f9
fix(build): Restore main, types, and files fields in rrvideo
chargome bbe2c35
fix(build): Restore playwright install hook and version in rrvideo
chargome 26981e6
fix(test): Disable Vite WebSocket to prevent console snapshot pollution
chargome e3f260a
fix(test): Filter Vite client console events from snapshot assertions
chargome 5fa4ca5
Apply formatting changes
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,14 +21,15 @@ jobs: | |
| # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Node.js lts/* | ||
| uses: actions/setup-node@v3 | ||
| - name: Setup Node.js 20 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
| node-version: 20 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this what the SDKs are on? It's out of maintentance soon
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SDKs are on 18 still, but lts/* was blocking CI |
||
| cache: 'yarn' | ||
|
|
||
| - name: Install Dependencies | ||
| run: yarn install --frozen-lockfile | ||
| run: yarn install --frozen-lockfile --network-timeout 300000 | ||
| timeout-minutes: 10 | ||
|
|
||
| - name: Build Project | ||
| run: NODE_OPTIONS='--max-old-space-size=4096' yarn build:all | ||
|
|
@@ -58,14 +59,15 @@ jobs: | |
| - name: Checkout Repo | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node.js lts/* | ||
| uses: actions/setup-node@v3 | ||
| - name: Setup Node.js 20 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: lts/* | ||
| node-version: 20 | ||
| cache: 'yarn' | ||
|
|
||
| - name: Install Dependencies | ||
| run: yarn install --frozen-lockfile | ||
| run: yarn install --frozen-lockfile --network-timeout 300000 | ||
| timeout-minutes: 10 | ||
|
|
||
| - name: Build Project | ||
| run: NODE_OPTIONS='--max-old-space-size=4096' yarn build:all | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,43 @@ | ||
| { | ||
| "name": "rrvideo", | ||
| "version": "2.41.0", | ||
| "description": "transform rrweb session into video", | ||
| "description": "A tool for generating a video from a rrweb session", | ||
| "main": "build/index.js", | ||
| "bin": { | ||
| "rrvideo": "build/cli.js" | ||
| }, | ||
| "types": "build/index.d.ts", | ||
| "files": [ | ||
| "build", | ||
| "package.json" | ||
| ], | ||
| "types": "build/index.d.ts", | ||
| "scripts": { | ||
| "install": "playwright install", | ||
| "build": "tsc", | ||
| "test": "jest", | ||
chargome marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "check-types": "tsc -noEmit", | ||
| "watch": "tsc -w", | ||
| "dev": "ts-node src/cli.ts", | ||
| "test": "jest --forceExit", | ||
| "check-types": "tsc --noEmit", | ||
| "prepack": "yarn build" | ||
| }, | ||
| "author": "yanzhen@smartx.com", | ||
| "bin": { | ||
| "rrvideo": "./build/cli.js" | ||
| }, | ||
| "license": "MIT", | ||
| "devDependencies": { | ||
| "dependencies": { | ||
| "@open-tech-world/cli-progress-bar": "^2.0.2", | ||
| "@sentry-internal/rrweb-player": "2.41.0", | ||
| "@sentry-internal/rrweb-types": "2.41.0", | ||
| "@types/fs-extra": "11.0.1", | ||
| "fs-extra": "^10.0.1", | ||
| "minimist": "^1.2.6", | ||
| "playwright": "^1.56.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/fs-extra": "^9.0.13", | ||
| "@types/jest": "^27.4.1", | ||
| "@types/minimist": "^1.2.1", | ||
| "@types/node": "^18.15.11", | ||
| "jest": "^27.5.1", | ||
| "ts-jest": "^27.1.3" | ||
| }, | ||
| "dependencies": { | ||
| "@open-tech-world/cli-progress-bar": "^2.0.2", | ||
| "@sentry-internal/rrweb-player": "2.41.0", | ||
| "fs-extra": "^11.1.1", | ||
| "minimist": "^1.2.5", | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "playwright": "^1.56.1" | ||
| "engines": { | ||
| "node": ">=12" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.