feat(pipedream): allow rollback final_pipeline override#99
Open
joseph-sentry wants to merge 3 commits into
Open
feat(pipedream): allow rollback final_pipeline override#99joseph-sentry wants to merge 3 commits into
joseph-sentry wants to merge 3 commits into
Conversation
Add optional `rollback.final_pipeline` to anchor the rollback material on an earlier group instead of the last pipeline in the chain. Useful when the tail group is flaky and would otherwise starve the rollback target pool. Errors at compile time if the named group doesn't exist. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 86ee098. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Material is keyed {pipeline}-{final_stage}; final_stage defaults to the
appended pipeline-complete stage, not the deploy stage.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
rollback.final_pipelineto the pipedream config. It anchors the rollback pipeline's dependency material on a named group's final stage instead of the default (last pipeline in the chain).When the tail group (e.g.
st) is flaky, the rollback material rarely reaches its final stage, starving the pool of rollback-eligible SHAs. Anchoring on an earlier group (e.g.us) lets a SHA become rollback-eligible sooner.This caused an issue with rolling back during an inc recently, since our last stage hadn't run successfully for a week, meaning that we had to fix forward, which took longer than if we were to just rollback.
Trade-off (documented): an upstream-anchored target may not have been validated on the downstream groups the rollback then deploys it to.
🤖 Generated with Claude Code