fix: guard runtime IPC by owner PID#158
Merged
Merged
Conversation
Capture the process that started the handler and reject runtime control IPC from other processes using OS-provided peer identity. Cover Windows named-pipe peer PIDs, Linux socket credentials, and macOS Mach audit trailers. Pass the macOS owner PID as --client-pid during handler startup.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JoshuaMoelans
approved these changes
Jul 9, 2026
JoshuaMoelans
left a comment
JoshuaMoelans
left a comment
Member
There was a problem hiding this comment.
LGTM just one open question
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c5507fa. Configure here.
Collaborator
Author
|
Running sentry-native CI: |
mujacica
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture the process ID that started
crashpad_handlerand reject IPC requests from any other processes. This restricts attachment updates and retry requests to the handler owner across Windows named pipes, Linux socket credentials, and macOS Mach audit trailers.See also: