Fix null-checking logic in IndexView.razor#76
Merged
justinyoo merged 2 commits intofeat/cacading-parametersfrom Jan 2, 2026
Merged
Fix null-checking logic in IndexView.razor#76justinyoo merged 2 commits intofeat/cacading-parametersfrom
justinyoo merged 2 commits intofeat/cacading-parametersfrom
Conversation
Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update cascading parameters for theme views based on feedback
Fix null-checking logic in IndexView.razor
Jan 2, 2026
justinyoo
approved these changes
Jan 2, 2026
justinyoo
added a commit
that referenced
this pull request
Jan 2, 2026
* Update to cascading parameters * Refactor StaticSiteGenerator * Refactor ScissorHandsApplication to builder * Add more tests * Update README * Update src/ScissorHands.Web/Generators/StaticSiteGenerator.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix null-checking logic in IndexView.razor (#76) * Initial plan * Fix null-checking logic in IndexView.razor Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Use reflection to discover cascading parameters in ComponentRenderer (#75) * Initial plan * Refactor ComponentRenderer to use reflection for cascading parameter detection Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Improve reflection to auto-discover cascading parameters from entire Theme assembly Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Add error handling and use GetExportedTypes for safer reflection Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Improve reflection-based method invocation with caching and error handling (#77) * Initial plan * Add robust error handling and caching for reflection-based method invocation Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Add thread-safety and improve exception handling Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> * Address final code review feedback - constants and stack trace preservation Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: justinyoo <1538528+justinyoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The null-checking condition
Documents?.Any() == falseincorrectly handles null values. WhenDocumentsis null,null?.Any()returnsnull, makingnull == falseevaluate tofalse, which skips the welcome message and proceeds to iterate overDocuments!, risking a NullReferenceException.Changes:
Documents?.Any() == falsetoDocuments?.Any() != trueelseblock to ensure it only executes when Documents contains itemsThis correctly handles all cases:
Documentsis null →null != true→ show welcomeDocumentsis empty →false != true→ show welcomeDocumentshas items →true != true→ iterate💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.