Fix: set PostgreSQL credentials in dev config to be the same as in se…#1112
Conversation
|
@sadiqkhoja this change makes sense to me; does it fit with your use of |
|
The change looks good to me. But I would prefer backend code to be changed to have |
I think moving away from |
alxndrsn
left a comment
There was a problem hiding this comment.
Standardising with https://github.com/getodk/central-backend/blob/master/config/default.json and reducing manual steps in dev environment setup is very helpful IMO.
Closes #1111
What has been done to verify that this works as intended?
Successfully started PostgreSQL container with docker-compose.dev.yml (
make dev) and run migrations (cd server && make)Why is this the best possible solution? Were any other approaches considered?
It synchronizes credentials across docker and server configs. Another approach would be to change credentials in server config or guide developers to change them manually.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Doesn't affect users.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)