Conversation
Contributor
|
Hi, I am actually quite confused with the final connection being ibis.postgres! This is not related to Amazon Redshift at all no? Looking in aws doc a little I found this: https://pypi.org/project/redshift-connector/ which should not be hard to use with your current implementation. Tell me if I am totally missing something here |
Contributor
Author
|
Hi, good question, I wanted to use ibis to connect to Redshift, but there is no specific API for redshift. I read that you can use the PostgreSQL pattern since Redshift is PostgreSQL-compatible. That is why I used it |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #112
Implented redshift connection :