Skip to content

[Bug Fix] http sink NEP checkpoint restore issue #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DonkeyHu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Bug Fix] http sink NEP checkpoint restore issue #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5136fc2
[Bug Fix] http sink NEP checkpoint restore issue
DonkeyHu Nov 25, 2025
63e7754
[Bug Fix] extract common method for schema open
DonkeyHu Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Changelog

## [Unreleased]
### Fixed
- Fixed http sink NEP issue when flink job restore from checkpoint.

## [0.23.0] - 2025-11-07

Expand Down
16 changes: 11 additions & 5 deletions src/main/java/com/getindata/connectors/http/internal/sink/HttpSinkInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,7 @@ protected HttpSinkInternal(
public StatefulSinkWriter<InputT, BufferedRequestState<HttpSinkRequestEntry>> createWriter(
InitContext context) throws IOException {

ElementConverter<InputT, HttpSinkRequestEntry> elementConverter = getElementConverter();
if (elementConverter instanceof SchemaLifecycleAwareElementConverter) {
// This cast is needed for Flink 1.15.3 build
((SchemaLifecycleAwareElementConverter<?, ?>) elementConverter).open(context);
}
ElementConverter<InputT, HttpSinkRequestEntry> elementConverter = initElementConverterOfSchema(context);

return new HttpSinkWriter<>(
elementConverter,
Expand All @@ -144,12 +140,22 @@ public StatefulSinkWriter<InputT, BufferedRequestState<HttpSinkRequestEntry>> cr
);
}

private ElementConverter<InputT, HttpSinkRequestEntry> initElementConverterOfSchema(InitContext context) {
ElementConverter<InputT, HttpSinkRequestEntry> elementConverter = getElementConverter();
if (elementConverter instanceof SchemaLifecycleAwareElementConverter) {
((SchemaLifecycleAwareElementConverter<?, ?>) elementConverter).open(context);
}
return elementConverter;
}

@Override
public StatefulSinkWriter<InputT, BufferedRequestState<HttpSinkRequestEntry>> restoreWriter(
InitContext context,
Collection<BufferedRequestState<HttpSinkRequestEntry>> recoveredState)
throws IOException {

initElementConverterOfSchema(context);
Copy link
Collaborator

@davidradl davidradl Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please could you add a unit test for the new line.


return new HttpSinkWriter<>(
getElementConverter(),
context,
Expand Down