Refactor form initialization to enable optional password updates

[giuscris]

This pull request introduces enhancements to the handling of password fields and streamlines the initialization of field values across several controller methods. The most significant change is the addition of new methods to the password field type, allowing for more flexible handling of empty values. Additionally, redundant checks for HTTP request methods when setting initial field values have been removed from multiple controllers, simplifying the codebase and ensuring that field validation state is always initialized.

Password field enhancements:

• Added ignoreEmpty and setValue methods to the password field type in password.php, allowing the field to retain its value if empty and the ignoreEmpty option is enabled. This helps prevent overwriting existing passwords with empty values during form submissions.
• Updated the password field view to set the required attribute only if the field is required and not set to ignore empty values, improving user experience and validation accuracy.

Field initialization and validation simplification:

• Removed conditional checks for RequestMethod::GET when setting initial field values and pre-validating fields in the edit and options methods of FilesController, PagesController, OptionsController, PluginsController, and UsersController. Now, field values are always initialized and validated, regardless of the request method, reducing code complexity and potential inconsistencies. [1] [2] [3] [4] [5] [6]

Code cleanup:

• Removed unused imports of RequestMethod from several controller files, as the related conditional logic has been eliminated. [1] [2] [3] [4] [5]

[Copilot]

Pull request overview

Refactors panel form initialization to consistently seed field values (and validation state) across several controllers, while enhancing the password field type to support optional updates without overwriting existing values with empties.

Changes:

• Added ignoreEmpty() and setValue() field-type methods for password fields to optionally preserve the previous value when an empty value is set.
• Updated the password field view so the required attribute is omitted when ignoreEmpty is enabled.
• Simplified multiple panel controllers by removing RequestMethod::GET guards and always initializing field values + validation state.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
panel/views/fields/password.php	Makes required conditional on ignoreEmpty for password inputs.
formwork/fields/password.php	Introduces ignoreEmpty and setValue hooks to preserve existing password values on empty input.
formwork/src/Panel/Controllers/UsersController.php	Always seeds user profile field values and pre-validates to initialize validation state.
formwork/src/Panel/Controllers/PluginsController.php	Always seeds plugin option field values and pre-validates to initialize validation state.
formwork/src/Panel/Controllers/PagesController.php	Always seeds page editor field values and pre-validates to initialize validation state.
formwork/src/Panel/Controllers/OptionsController.php	Always seeds system/site options values and pre-validates to initialize validation state.
formwork/src/Panel/Controllers/FilesController.php	Always seeds file metadata values and pre-validates to initialize validation state.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.