Skip to content

Add white-active tab background support #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arifulhoque7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add white-active tab background support #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/components/ui/Tabs.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type Story = StoryObj<typeof meta>;

export const Default: Story = {
render: () => (
<Tabs defaultValue="tab1" className="w-[400px]">
<Tabs defaultValue="tab1" className="w-100">
<TabsList>
<TabsTrigger value="tab1">Tab 1</TabsTrigger>
<TabsTrigger value="tab2">Tab 2</TabsTrigger>
Expand All @@ -29,7 +29,7 @@ export const Default: Story = {

export const LineVariant: Story = {
render: () => (
<Tabs defaultValue="a" className="w-[400px]">
<Tabs defaultValue="a" className="w-100">
<TabsList variant="line">
<TabsTrigger value="a">Account</TabsTrigger>
<TabsTrigger value="b">Password</TabsTrigger>
Expand All @@ -39,3 +39,20 @@ export const LineVariant: Story = {
</Tabs>
),
};

export const ActiveWhiteBackground: Story = {
render: () => (
<div className="rounded-lg">
<Tabs defaultValue="tab1" className="w-100">
<TabsList activeColor="white">
<TabsTrigger value="tab1">Tab 1</TabsTrigger>
<TabsTrigger value="tab2">Tab 2</TabsTrigger>
<TabsTrigger value="tab3">Tab 3</TabsTrigger>
</TabsList>
<TabsContent value="tab1">Content for tab 1.</TabsContent>
<TabsContent value="tab2">Content for tab 2.</TabsContent>
<TabsContent value="tab3">Content for tab 3.</TabsContent>
</Tabs>
</div>
),
};
7 changes: 6 additions & 1 deletion src/components/ui/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,16 @@ const tabsListVariants = cva(
function TabsList({
className,
variant = "default",
activeColor,
...props
}: TabsPrimitive.List.Props & VariantProps<typeof tabsListVariants>) {
}: TabsPrimitive.List.Props & VariantProps<typeof tabsListVariants> & {
activeColor?: "white"
}) {
return (
<TabsPrimitive.List
data-slot="tabs-list"
data-variant={variant}
data-active-color={activeColor}
className={cn(tabsListVariants({ variant }), className)}
{...props}
/>
Expand All @@ -59,6 +63,7 @@ function TabsTrigger({ className, ...props }: TabsPrimitive.Tab.Props) {
"gap-1.5 rounded-md border border-transparent px-2 py-1 text-sm font-medium group-data-[variant=default]/tabs-list:data-active:shadow-sm group-data-[variant=line]/tabs-list:data-active:shadow-none [&_svg:not([class*='size-'])]:size-4 focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:outline-ring text-foreground/60 hover:text-foreground dark:text-muted-foreground dark:hover:text-foreground relative inline-flex h-[calc(100%-1px)] flex-1 items-center justify-center whitespace-nowrap transition-all group-data-vertical/tabs:w-full group-data-vertical/tabs:justify-start focus-visible:ring-[3px] focus-visible:outline-1 disabled:pointer-events-none disabled:opacity-50 aria-disabled:pointer-events-none aria-disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0",
"group-data-[variant=line]/tabs-list:bg-transparent group-data-[variant=line]/tabs-list:data-active:bg-transparent dark:group-data-[variant=line]/tabs-list:data-active:border-transparent dark:group-data-[variant=line]/tabs-list:data-active:bg-transparent",
"data-active:bg-background dark:data-active:text-foreground dark:data-active:border-input dark:data-active:bg-input/30 data-active:text-foreground",
"group-data-[active-color=white]/tabs-list:data-active:bg-white group-data-[active-color=white]/tabs-list:dark:data-active:bg-white",
"after:bg-primary after:absolute after:opacity-0 after:transition-opacity after:inset-x-0 after:bottom-0 after:h-0.5 group-data-[variant=line]/tabs-list:data-active:after:opacity-100 group-data-[variant=line]/tabs-list:data-active:text-primary",
className
)}
Expand Down
Loading