SDKS-3732: Harden Claude security-update prompt to verify lockfile consistency#4
Open
John Cunningham (SausCode) wants to merge 2 commits into
Conversation
The previous prompt told Claude to verify with `npm install && npm run build`, but CI runs strict commands (`yarn install --immutable`, `npm ci`) that reject lockfile drift. Claude manually edited yarn.lock without updating the descriptor key, declared success, and opened a broken PR (#22600 in getditto/ditto). Changes: - Add yarn berry and yarn classic handling (step 3) - Replace lenient verification with strict CI-equivalent commands (step 4) - Add verification gate: must pass before declaring success - Prohibit manual lockfile edits - Pin to same major version unless CVE requires otherwise Tested by running the improved prompt against the ditto monorepo at the pre-fix commit — yarn install --immutable now passes where it previously failed. Resolves: SDKS-3732
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKS-3732: Harden Claude security-update prompt to verify lockfile consistency
SDKS-3732