Skip to content

Conversation

@im-adithya
Copy link
Member

@im-adithya im-adithya commented Jan 22, 2026

Fixes #428

Summary by CodeRabbit

  • Bug Fixes
    • Improved transaction status display to correctly prioritize and show appropriate icons for received, sent, sending, and failed transactions.

✏️ Tip: You can customize this high-level summary in your review settings.

@im-adithya im-adithya merged commit e1cece2 into master Jan 22, 2026
2 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updated the semantic mapping for transaction status and icon selection in TransactionItem.tsx to correctly prioritize transaction types and states. Changed the conditional logic to check incoming type first, followed by settled and pending states, with a fallback to failed status. This resolves incorrect display of expired outgoing transactions.

Changes

Cohort / File(s) Summary
Transaction Status Mapping
components/TransactionItem.tsx
Reordered conditional logic in typeStateText calculation and icon selection to prioritize incoming type (Received), then settled state (Sent), pending state (Sending), and fallback (Failed). Fixes expired transactions incorrectly displaying as sent.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop and a fix, the status now bright,
Expired transactions show "Failed," not "Sent" in the light!
With priorities straight, like a race to the goal,
Each icon and label now plays their true role. ✨

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: outgoing transaction in "expired" state shows as Sent in Alby Go

2 participants