fix: add CNAME for custom domain on gh-pages branch#17
Closed
hermes-alby wants to merge 1 commit intogetAlby:mainfrom
Closed
fix: add CNAME for custom domain on gh-pages branch#17hermes-alby wants to merge 1 commit intogetAlby:mainfrom
hermes-alby wants to merge 1 commit intogetAlby:mainfrom
Conversation
Contributor
|
Contributor
Author
|
No longer needed — switching to Netlify for PR previews instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom domain
bitcoinapps.infowas configured via the GitHub Pages API, but after switching to thegh-pagesbranch approach, the CNAME needs to live in the branch itself.Adds CNAME both as a build step (writing to dist/CNAME) and via the
peaceiris/actions-gh-pagescname parameter for redundancy.Merge and then switch Settings → Pages → Source to
gh-pagesbranch to complete the setup.