Fix race condition: Atomic stream finish with message save by sethconvex · Pull Request #224 · get-convex/agent

sethconvex · 2026-02-11T00:49:38Z

Summary

Fixes the intermittent crash "TypeError: The stream is not in a state that permits enqueue" when using saveStreamDeltas with tool calls (issue #181).

The bug occurs when:

Tool executes successfully → onStepFinish callback saves to DB
Stream finishes reading → AI SDK closes stream via attemptClose()
Delta-save mutation still in flight → tries to write to closed stream
Crash: Cannot enqueue chunk on closed stream

The fix implements atomic stream finish by:

Deferring final step save when streaming is enabled
Saving step atomically with stream finish in same mutation
Stream stays open until database confirms all saves complete

Cherry-picked from #217 (commit 5cd4c5e). Resolves #181.

Test plan

npm run build passes
npm test passes
No more "stream is not in a state that permits enqueue" errors during tool calling with streaming

🤖 Generated with Claude Code

coderabbitai · 2026-02-11T00:49:45Z

Warning

Rate limit exceeded

@sethconvex has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 6 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-atomic-stream-finish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sethconvex · 2026-02-11T00:49:55Z

Add tool approval example: agent, backend, UI, and E2E tests #226
Add tool approval support with approveToolCall/denyToolCall #222
Add compile-time errors for AI SDK v5 patterns and docs #225
Fix race condition: Atomic stream finish with message save #224 👈 (View in Graphite)
Fix example tools for AI SDK v6 and remove noisy warning #223
AI SDK v6 Support #216 : 1 other dependent PR (#217 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

pkg-pr-new · 2026-02-11T01:14:59Z

Open in StackBlitz

npm i https://pkg.pr.new/get-convex/agent/@convex-dev/agent@224

commit: 5264d40

ianmacartney · 2026-02-20T01:01:53Z

src/client/start.ts

          messages: serialized.messages,
          embeddings,
          failPendingSteps: false,
+          finishStreamId: finishStreamId as any, // optional stream to finish atomically


why the any cast?

ianmacartney · 2026-02-20T01:04:12Z

src/client/streaming.ts

+  public async getOrCreateStreamId(): Promise<string> {
+    await this.getStreamId();
+    return this.streamId!;


let's just have getStreamId() return this.streamId

ianmacartney · 2026-02-20T01:04:33Z

src/client/streamText.ts

+
+  // If we deferred the final step save, do it now with atomic stream finish
+  if (pendingFinalStep && streamer) {
+    const finishStreamId = await streamer.getOrCreateStreamId();


not sure why the streamId wouldn't exist yet - but i guess better than streamer.streamId!?

ianmacartney · 2026-02-20T01:06:30Z

src/component/messages.ts

+  if (args.finishStreamId) {
+    await finishHandler(ctx, { streamId: args.finishStreamId });


Suggested change

if (args.finishStreamId) {

await finishHandler(ctx, { streamId: args.finishStreamId });

if (finishStreamId) {

await finishHandler(ctx, { streamId: finishStreamId });

sethconvex · 2026-02-20T06:51:45Z

Addressed review feedback:

as any cast (start.ts:274): Added comment explaining why — finishStreamId is string from getOrCreateStreamId(), but the component mutation expects Id<"streamingMessages">. Runtime validation handles it.
getStreamId() return value (streaming.ts:264): Refactored to always return this.streamId. getOrCreateStreamId() now just delegates to getStreamId() directly.
streamText.ts:169: The stream is created by this point (via addParts → getStreamId() during streaming). getOrCreateStreamId is just the public accessor.

sethconvex · 2026-02-20T07:25:26Z

Merge activity

Feb 20, 7:25 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Feb 20, 7:26 AM UTC: Graphite rebased this pull request as part of a merge.
Feb 20, 7:27 AM UTC: @sethconvex merged this pull request with Graphite.

Fixes the intermittent crash "TypeError: The stream is not in a state that permits enqueue" when using saveStreamDeltas with tool calls. The bug occurs when: 1. Tool executes successfully -> onStepFinish callback saves to DB 2. Stream finishes reading -> AI SDK closes stream via attemptClose() 3. Delta-save mutation still in flight -> tries to write to closed stream 4. Crash: Cannot enqueue chunk on closed stream This fix (from commit 87e3657 on seth/fix-193 branch) implements atomic stream finish by: - Deferring final step save when streaming is enabled - Saving step atomically with stream finish in same mutation - Stream stays open until database confirms all saves complete Changes: - streamText.ts: Track pendingFinalStep, defer save, atomic finish - streaming.ts: Add markFinishedExternally() and getOrCreateStreamId() - start.ts: Add finishStreamId parameter to save() - messages.ts: Atomically finish stream with message save Resolves issue #181 Addresses user report: #217 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

sethconvex mentioned this pull request Feb 11, 2026

Add tool approval support with approveToolCall/denyToolCall #222

Merged

2 tasks

This was referenced Feb 11, 2026

Fix example tools for AI SDK v6 and remove noisy warning #223

Merged

Add compile-time errors for AI SDK v5 patterns and docs #225

Merged

sethconvex force-pushed the fix-atomic-stream-finish branch from 3122e0e to fa9cadc Compare February 11, 2026 01:14

sethconvex mentioned this pull request Feb 11, 2026

Add tool approval example: agent, backend, UI, and E2E tests #226

Merged

4 tasks

ianmacartney approved these changes Feb 20, 2026

View reviewed changes

sethconvex force-pushed the fix-v6-examples-and-warnings branch from a19d166 to c209e89 Compare February 20, 2026 06:34

sethconvex force-pushed the fix-atomic-stream-finish branch 2 times, most recently from 462e158 to cf75fc1 Compare February 20, 2026 06:51

sethconvex force-pushed the fix-atomic-stream-finish branch from cf75fc1 to b6894b8 Compare February 20, 2026 06:59

sethconvex force-pushed the fix-v6-examples-and-warnings branch from c209e89 to 0eb6f6a Compare February 20, 2026 07:12

sethconvex force-pushed the fix-atomic-stream-finish branch from b6894b8 to 34d83da Compare February 20, 2026 07:12

sethconvex force-pushed the fix-v6-examples-and-warnings branch 2 times, most recently from 17cd6b6 to b25ec92 Compare February 20, 2026 07:21

sethconvex force-pushed the fix-atomic-stream-finish branch from 34d83da to 15c0ddf Compare February 20, 2026 07:21

sethconvex marked this pull request as ready for review February 20, 2026 07:25

sethconvex changed the base branch from fix-v6-examples-and-warnings to graphite-base/224 February 20, 2026 07:25

sethconvex changed the base branch from graphite-base/224 to main February 20, 2026 07:25

sethconvex and others added 2 commits February 20, 2026 07:26

[checkpoint] Auto-save at 10:50:48 PM

5264d40

sethconvex force-pushed the fix-atomic-stream-finish branch from 15c0ddf to 5264d40 Compare February 20, 2026 07:26

sethconvex merged commit 6998f79 into main Feb 20, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix race condition: Atomic stream finish with message save#224

Fix race condition: Atomic stream finish with message save#224
sethconvex merged 2 commits intomainfrom
fix-atomic-stream-finish

sethconvex commented Feb 11, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 11, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

sethconvex commented Feb 11, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

ianmacartney Feb 20, 2026

Uh oh!

ianmacartney Feb 20, 2026

Uh oh!

ianmacartney Feb 20, 2026

Uh oh!

ianmacartney Feb 20, 2026

Uh oh!

sethconvex commented Feb 20, 2026

Uh oh!

sethconvex commented Feb 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		if (args.finishStreamId) {
		await finishHandler(ctx, { streamId: args.finishStreamId });

Conversation

sethconvex commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

coderabbitai bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

sethconvex commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianmacartney Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

ianmacartney Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

ianmacartney Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

ianmacartney Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

sethconvex commented Feb 20, 2026

Uh oh!

sethconvex commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sethconvex commented Feb 11, 2026 •

edited

Loading

coderabbitai bot commented Feb 11, 2026 •

edited

Loading

sethconvex commented Feb 11, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 11, 2026 •

edited

Loading

sethconvex commented Feb 20, 2026 •

edited

Loading