fix: unify the footer across all pages, fix it and add pnpm workspace#223
Conversation
There was a problem hiding this comment.
Pull request overview
Moves the <Footer /> out of individual pages into the shared [locale]/layout.tsx so the footer is consistent across all routes, simplifies Footer to no longer accept an introRef (it now always scrolls to top), and adds a pnpm-workspace.yaml intended to approve native install scripts for a few packages.
Changes:
- Render
Footeronce inapp/[locale]/layout.tsxand remove per-pageFooterusage frompage.tsx,contributors/page.tsx, andart/page.tsx. - Convert
Footerto a client component ("use client"), drop theintroRefprop, and simplify scroll-up towindow.scrollTo. - Add
pnpm-workspace.yamlto allow build scripts for@parcel/watcher,@swc/core,sharp, andunrs-resolver.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | New workspace file attempting to allow native install scripts. |
| components/footer/Footer.tsx | Marks Footer as client component, removes introRef prop, simplifies scroll-up. |
| app/[locale]/layout.tsx | Imports and renders <Footer /> inside the locale layout. |
| app/[locale]/page.tsx | Removes the now-redundant <Footer introRef={introRef} />. |
| app/[locale]/contributors/page.tsx | Removes the per-page <Footer /> and its import. |
| app/[locale]/art/page.tsx | Removes the per-page <Footer /> and its import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Fixes the footer by moving it to the layout file, unifies it across all pages, and adds a pnpm-workspace.yml file due to new supply-chain things that contains trusted dependencies that need to build for the website to work for dev locally. Exciting.