Skip to content

fix: unify the footer across all pages, fix it and add pnpm workspace#223

Merged
NiHaiden merged 1 commit into
mainfrom
footer-unification
May 31, 2026
Merged

fix: unify the footer across all pages, fix it and add pnpm workspace#223
NiHaiden merged 1 commit into
mainfrom
footer-unification

Conversation

@NiHaiden
Copy link
Copy Markdown
Member

Fixes the footer by moving it to the layout file, unifies it across all pages, and adds a pnpm-workspace.yml file due to new supply-chain things that contains trusted dependencies that need to build for the website to work for dev locally. Exciting.

Copilot AI review requested due to automatic review settings May 31, 2026 23:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the <Footer /> out of individual pages into the shared [locale]/layout.tsx so the footer is consistent across all routes, simplifies Footer to no longer accept an introRef (it now always scrolls to top), and adds a pnpm-workspace.yaml intended to approve native install scripts for a few packages.

Changes:

  • Render Footer once in app/[locale]/layout.tsx and remove per-page Footer usage from page.tsx, contributors/page.tsx, and art/page.tsx.
  • Convert Footer to a client component ("use client"), drop the introRef prop, and simplify scroll-up to window.scrollTo.
  • Add pnpm-workspace.yaml to allow build scripts for @parcel/watcher, @swc/core, sharp, and unrs-resolver.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml New workspace file attempting to allow native install scripts.
components/footer/Footer.tsx Marks Footer as client component, removes introRef prop, simplifies scroll-up.
app/[locale]/layout.tsx Imports and renders <Footer /> inside the locale layout.
app/[locale]/page.tsx Removes the now-redundant <Footer introRef={introRef} />.
app/[locale]/contributors/page.tsx Removes the per-page <Footer /> and its import.
app/[locale]/art/page.tsx Removes the per-page <Footer /> and its import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pnpm-workspace.yaml
@NiHaiden NiHaiden merged commit 841673d into main May 31, 2026
2 of 3 checks passed
@NiHaiden NiHaiden deleted the footer-unification branch May 31, 2026 23:34
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants