Add lowercase tests for >NUMBER #42
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using this test suite to test the Forth-2012 System I was developing and it passing the Core tests, I wrote a program that relied on parsing numbers with
>NUMBERthat had lowercase digits in bases larger than 10, which failed on my System. Section 3.2.1.2 of the Forth-2012 Standard specifies that lowercase digits are treated as if they were uppercase digits.This PR adds four tests to the
>NUMBERsection that are similar to the last four presently there, testing parsing of lowercase digits in bases larger than 10. I tested these in gForth 0.7.9 and my System.I don't know if this is the preferred way to implement these tests. If having lowercase characters between the ticks is unwanted, my other idea was to make another word named
GNLOWER'that is identical toGN', except for adding 0x20 to the char before storing it intoGN-BUF.