Skip to content

Dynamic Filter Widget: "APPLY DIMENSION" to update Time and Elevation #12267#12347

Open
rowheat02 wants to merge 7 commits into
geosolutions-it:masterfrom
rowheat02:applyDimension
Open

Dynamic Filter Widget: "APPLY DIMENSION" to update Time and Elevation #12267#12347
rowheat02 wants to merge 7 commits into
geosolutions-it:masterfrom
rowheat02:applyDimension

Conversation

@rowheat02
Copy link
Copy Markdown
Contributor

@rowheat02 rowheat02 commented May 7, 2026

Description

This PR adds Apply Dimension as an optional target for interactions. Can connect to update the layer time and elevation. If a timeline exists, a different global node "MapTime" to control currentTime of timeline

Here are the conditions applied for Apply Dimension

  • Maptime(target) can only be connected alone; other targets can not be connected on the same filter. This is done to make consistent reerse sync.
  • When range is enabled in timeline, mapTime connected widget will be disabled
  • An apply dimension node can only be connected when selection mode is "Single"
  • For elevation, the value field must be numeric, and for time, it must be datetime/date

Demo for Map:

Screen.Recording.2026-05-07.at.20.42.18.compressed.mp4

Demo for Dashboard

Screen.Recording.2026-05-07.at.20.57.23.compressed.mp4

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

#12267

What is the new behavior?

The user can connect the dimension update node of the layer(time and elevation)

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@cla-bot cla-bot Bot added the CLA Ready label May 7, 2026
@rowheat02 rowheat02 added this to the 2026.01.02 milestone May 7, 2026
@rowheat02 rowheat02 requested a review from offtherailz May 7, 2026 15:19
@rowheat02 rowheat02 linked an issue May 7, 2026 that may be closed by this pull request
1 task
@rowheat02 rowheat02 marked this pull request as ready for review May 7, 2026 15:21
Copy link
Copy Markdown
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to check the code. Make sure to design the application with best practices. I see a lot of code and ifs that looks to be hard to maintain

  • Conditional Visibility for "+" Button: it should show when at least one additional event can be added. In the stile case, when userDefined style is selected. In case of apply dimension it only appears when a dimension can actually be applied. This prevents users from clicking an action that has no effect.
  • Option vetical/horizonal makes no sense on slider (or still not supported) disable it.
  • Implement backward compatibility for missing attribute types.
  • See comments inline

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic for dimension should be isolated somehow. Interaction row component can not contain the logic for every possible target.
Or we have different components for different actions to do (that maybe share a basic graphic component, that allows to place the row icon, text, tooltops, components etc..., if makes sense), or a logic should be in the container using component. This depends of course on the items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Filter Widget: "APPLY DIMENSION" to update Time and Elevation

2 participants