make Nominatim host and protocol configurable via search service options#12316
Open
jwkaltz wants to merge 3 commits intogeosolutions-it:masterfrom
Open
make Nominatim host and protocol configurable via search service options#12316jwkaltz wants to merge 3 commits intogeosolutions-it:masterfrom
jwkaltz wants to merge 3 commits intogeosolutions-it:masterfrom
Conversation
added 3 commits
April 27, 2026 16:05
…protocol overrideable; add tests for Nominatim
…protocol overrideable
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Wolfgang Kaltz.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructure nominatim URL construction in order to make hostname and protocol overrideable.
Add tests for Nominatim.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
The Nominatim geocoding endpoint is currently hardcoded as
https://nominatim.openstreetmap.orginweb/client/api/nominatim.js.This prevents users from configuring a custom Nominatim instance, which is required for:
What is the new behavior?
Read
hostandprotocolfrom the serviceoptionsobject, falling back to the current defaults if not provided. This is fully backwards compatible — existing configurations continue to work unchanged.Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
After this change, there will be more options in
localConfig.jsonor viaoverrideLocalConfig:{ "type": "nominatim", "priority": 5, "options": { "host": "my-nominatim.example.com", "protocol": "https", "limit": 10, "polygon_geojson": 1 } }