Introduce slider varient for Dynamic filter #12268#12311
Merged
offtherailz merged 16 commits intoMay 5, 2026
Merged
Conversation
1 task
Member
|
Hi, Screencast.from.2026-04-28.18-25-23.webm |
offtherailz
requested changes
Apr 29, 2026
2ea4870 to
cb8b00e
Compare
Contributor
Author
|
@offtherailz So we must give height to the slider. In the elevation profile also they have given fix height to the slider. One enhancement is done. As SLider is a horizontal component, the max height is not crucial(so replaced with height). Screen.Recording.2026-04-30.at.14.34.10.mov |
offtherailz
requested changes
May 5, 2026
Member
There was a problem hiding this comment.
It looks good, I have a couple of minor corrections:
- I have the console.error flooded of errors of type:
installHook.js:1 Warning: Encountered two children with the same key, `4.42`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.
They should be removed
- In order to have a better compatibility, also for the future, if the variant is unknown, it is better to soft fail, showing simply an advice on the widget. Instead this makes the whole application crash.
if (!Component) {
throw new Error(`Unsupported filter variant: ${layout.variant}`);
}
Contributor
Author
…iderVarientForDyanamicFilter
offtherailz
approved these changes
May 5, 2026
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This PR adds a Slider UI option for dynamic filters in the widget builder. Users can now configure dynamic filters as sliders, including layout settings and validation/warning states.

Screen.Recording.2026-04-28.at.11.26.53.mov
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12268
What is the new behavior?
New Slider Ui is introduced for Single selection mode.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
What is different from the issue description?