Add the support for the non spatial dataset in feature grid and disabling tools that interacts with map#11797
Merged
allyoucanmap merged 7 commits intogeosolutions-it:masterfrom Jan 30, 2026
Conversation
6 tasks
…ling tools that interacts with map
subashtiwari1010
force-pushed
the
feat/improve-featuregrid-layout-11746
branch
from
3824208 to
08bc1e4
Compare
…at/improve-featuregrid-layout-11746
…at/improve-featuregrid-layout-11746
allyoucanmap
requested changes
Jan 30, 2026
Contributor
allyoucanmap
left a comment
allyoucanmap
left a comment
There was a problem hiding this comment.
@subashtiwari1010 the implementation seems fine,
please include unit tests to cover the introduced changes
Contributor
|
@subashtiwari1010 please also resolve conflict |
allyoucanmap
approved these changes
Jan 30, 2026
Contributor
|
@ElenaGallo please test this fix on dev, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the functionality of the feature grids toolbar so that it supports the non-spatial dataset. It disables all the tools that interacts with the map as such functionality is not related to the dataset with no geometry. The functionality such as Draw geometry, sync map with filter, snapping, filter data by current viewport, delete geometry is hidden from the feature grid.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
All the tools are available for the feature grid even though some of the functionality is not needed for the non spatial dataset.
#11795
What is the new behavior?
The tools that are not needed or are not relevant for the non spatial dataset are disabled/removed from the UI in the feature grid.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
PR #11789 is needed for the functionality of this PR.