[FEATURE] Allow a list of domains#64
Open
PVerstappen wants to merge 6 commits intogeorgringer:masterfrom
Open
Conversation
added 6 commits
June 8, 2021 17:47
PVerstappen
changed the title
FamousWolf
approved these changes
Jun 25, 2021
liayn
reviewed
Oct 17, 2023
| } | ||
|
|
||
| $allowedIpsResult = ''; | ||
| if($allowedIps !== '*' && !empty($allowedIps)) { |
Collaborator
There was a problem hiding this comment.
Please apply PSR coding standards to all files. (space after if)
|
|
||
| /* Convert the domain names to IP addresses */ | ||
| if($allowedDomains !== '*' && !empty($allowedDomains)) { | ||
| $allowedDomainsArray = explode(',', $allowedDomains); |
Collaborator
There was a problem hiding this comment.
use GeneralUtility::trimExplode instead
| } | ||
|
|
||
| /* Return concatenated IPs and domains IPs */ | ||
| return trim($allowedIpsResult, ' ,'); |
Collaborator
There was a problem hiding this comment.
collect the resulting IPs in an array first and do the implode here-
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature implements
allowedDomainsnext toallowedIps, retrieves IPs from the DNS and merges it automatically with the allowedIps list.