Optimize DnonDn forward pass and increase test coverage to 96%#38
Merged
Optimize DnonDn forward pass and increase test coverage to 96%#38
Conversation
- Eliminate Python for-loop in DnonDn.forward by batching all CG-transformed bispectrum computations: precomputed Fplus gather indices, single einsum for kron products, batched matmul chain. Speedup: 2.41ms -> 0.55ms (4.4x). - Add test_coverage_gaps.py with 39 edge-case tests covering _bessel, _cg, dn_on_dn, so3_on_s2, octa_on_octa, rotation, and torus_on_torus modules. - Overall test coverage: 91% -> 96%. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DnonDn.forwardby precomputing Fplus gather indices, using a singleeinsumfor Kronecker products, and a batched matmul chain. Achieves 4.4x speedup (2.41ms → 0.55ms).tests/test_coverage_gaps.pywith 39 edge-case tests targeting_bessel,_cg,dn_on_dn,so3_on_s2,octa_on_octa,rotation, andtorus_on_torus. Overall coverage: 91% → 96%.so3_on_s2.pyfor selective bispectrum edge case.Test plan
pytest tests/ -xpasses on CIMade with Cursor