Fix a variable name for the Weighted BFBT preconditioner.#6821
Merged
tjhei merged 1 commit intogeodynamics:mainfrom Jan 3, 2026
Merged
Fix a variable name for the Weighted BFBT preconditioner.#6821tjhei merged 1 commit intogeodynamics:mainfrom
tjhei merged 1 commit intogeodynamics:mainfrom
Conversation
tjhei
approved these changes
Dec 25, 2025
Member
|
test failure is unrelated, see #6822 |
Member
|
/rebuild |
quangx
force-pushed
the
variable_name
branch
from
ecc3646 to
da93dae
Compare
tjhei
reviewed
Dec 31, 2025
quangx
force-pushed
the
variable_name
branch
2 times, most recently
from
a70fe6a to
dd17877
Compare
tjhei
approved these changes
Jan 1, 2026
tjhei
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current implementation of Weighted BFBT uses a pressure Laplace operator to represent (BC^{-1}B^T). In the code, this pressure Laplace operator is called mp_matrix which is not an accurate description.
@tjhei