Skip to content

fix(sfx): Reload effect files when applying#70

Merged
poweredbypie merged 4 commits intogeode-sdk:mainfrom
poweredbypie:main
Mar 3, 2026
Merged

fix(sfx): Reload effect files when applying#70
poweredbypie merged 4 commits intogeode-sdk:mainfrom
poweredbypie:main

Conversation

@poweredbypie
Copy link
Copy Markdown
Member

@poweredbypie poweredbypie commented Jan 17, 2026

This has been tested on Windows only.
To recreate the bug on 1.9.0:

  • Create a texture pack with explode_11.ogg as something different (you can just copy endStart02 and rename it, or something like that)
  • Apply the pack
  • Kill an icon on the home screen
  • The default explode_11.ogg will play rather than the replaced one

This fixes the issue by forcing GD to reload the effect. Prior to this the effect was cached in a map, so it wouldn't recognize any changes during a reload.

@poweredbypie
Copy link
Copy Markdown
Member Author

Ok I just tested this a bit further and for some reason it only works one way (if you already have a pack applied it works, but if you're coming from the default and applying another pack it doesn't) so investigating that now

@poweredbypie
Copy link
Copy Markdown
Member Author

I was iterating the sounds map wrong and skipping half of them so that's fixed now. Looks to be fully functioning from what I can tell

@poweredbypie poweredbypie requested a review from matcool March 2, 2026 10:35
@poweredbypie poweredbypie merged commit 02e8558 into geode-sdk:main Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant