get_index query rewrite#70
Open
dankmeme01 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the SQL query in
Mod::get_indexto no longer be a large, monolithic query and instead adds joins and filters as they are needed. Additionally, it fixes potential logic holes in the query design. For example, previously, when requestinggd=2.208&geode=5.7.0mods it could return mods running Geodev5.0.0-alpha.1, which Geode would refuse to load. The new query will not return those mods. This is hopefully the only change to behavior observable from the outside.I ran a small stress test script that overwhelmed the server with requests to see how fast it can process them all, using a mix of typical queries (latest GD/Geode versions, random platform, everything else unset) and completely random queries to compare the performance, and with this PR the response times seem to be ~7.5 times faster. This should hopefully reduce the strain on the database by a ton
Also added some indexes, idk if completely correct but should be an improvement