add controller detection support from launcher#101
Draft
undefined06855 wants to merge 2 commits intogeode-sdk:mainfrom
Draft
add controller detection support from launcher#101undefined06855 wants to merge 2 commits intogeode-sdk:mainfrom
undefined06855 wants to merge 2 commits intogeode-sdk:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds controller detection support for Android by integrating with the launcher utility while keeping the legacy behavior for unsupported launchers intact.
- Introduces an Android-specific code block using conditional compilation and JniHelper to check for connected controllers.
- Removes legacy code and a constructor that previously retained the ControllerChecker instance in favor of launcher-based detection.
Comments suppressed due to low confidence (1)
src/main.cpp:276
- The constructor removal may affect the object's lifetime management. Please confirm that the retention of ControllerChecker instances is now handled elsewhere.
ControllerChecker() { this->retain(); }
| bool controllerConnected = GEODE_ANDROID(true || ) PlatformToolbox::isControllerConnected(); | ||
| #ifdef GEODE_IS_ANDROID | ||
| bool controllerConnected = true; | ||
| JniMethodInfo info; |
There was a problem hiding this comment.
After calling CallStaticIntMethod, consider releasing the JNI local reference (e.g., info.classID) if needed to avoid potential local reference leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires geode-sdk/android-launcher #47 to get merged first before this would work, but wont break on an unsupported launcher
(marked as draft until launcher pr is merged)