Complete rewrite (TypeScript)#28
Open
alanpoulain wants to merge 61 commits intogeocoder-php:masterfrom
Open
Conversation
This reverts commit 70dec6b.
Couscous action cannot launch Bower
* feat: better Yandex provider Make the use of bounds more coherent too. * chore: bump dev dependencies
The "latitude" and "longitude" parameters in GeocodeQuery are replaced by a "coordinates" parameter (an object with "latitude" and "longitude" keys). The same parameters in Geocoded are replaced by a "coordinates" parameter too. The GeoJsonDumper now uses "bbox" instead of "bounds". The "bounds" parameter in GeocodeQuery is now an object with "latitudeSW", "longitudeSW", "latitudeNE", "longitudeNE" keys. The same object is returned for the "bounds" field of Geocoded.
Add `precision` to `OpenCageGeocoded`. Replace `minConfidence` with `minPrecision` for geocode and geodecode. Use `FlatCoordinates`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a complete rewrite of GeocoderJS in TypeScript (and therefore a module support) and some more goodies (Mapbox, OpenCage and GeoPlugin providers, formatted address, time zone, bounds and country support).
I tried to not break everything and to follow the old API as much as possible.
Since the project seems not maintained anymore, I took the liberty to fork it and to publish it under a new name: Universal Geocoder (https://github.com/universal-geocoder/universal-geocoder-js).
I will maintain this branch (
ts) without the specific changes for Universal Geocoder in case you want to revive the project.Thank you for having creating this library and for maintaining the PHP version 🙂