adding https support on open street map call outs#19
Open
mbowen000 wants to merge 1 commit intogeocoder-php:masterfrom
Open
adding https support on open street map call outs#19mbowen000 wants to merge 1 commit intogeocoder-php:masterfrom
mbowen000 wants to merge 1 commit intogeocoder-php:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi - I am implementing reverse geocoding in a Salesforce implementation (hosted SaaS platform) and it required my API calls to OpenStreetMap to be HTTPS. I've switched that up in a fork - feel free to merge this PR if you want that change made. It works fine and all tests pass. I'm not a huge github contributor so feel free to let me know if there are any issues I can tweak or if there is a reason you'd rather default to HTTP.
Thanks!
Mike