Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Update reown swift to fix parsing bool wrongly#1717

Merged
gemcoder21 merged 1 commit intomainfrom
reown-bool-parse
Feb 20, 2026
Merged

Update reown swift to fix parsing bool wrongly#1717
gemcoder21 merged 1 commit intomainfrom
reown-bool-parse

Conversation

@0xh3rman
Copy link
Copy Markdown
Contributor

Found when testing WalletConnect x Tron, bool type is parsed as Int wrongly: gemwalletcom/reown-swift@ba9656f

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the reown-swift submodule to resolve a critical parsing error. The update ensures that boolean values are correctly interpreted, preventing them from being mistakenly treated as integers, which was causing issues in WalletConnect x Tron integrations.

Highlights

  • Submodule Update: The reown-swift submodule has been updated to a newer commit (ba9656fb9762929ca1c1233b8c7b7fefee17f09b) to incorporate a critical bug fix.
  • Boolean Parsing Fix: This update specifically addresses an issue where boolean types were incorrectly parsed as integers, which was identified during WalletConnect x Tron testing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Submodules/reown-swift
    • Updated the submodule to incorporate a fix for boolean parsing.
Activity
  • The reown-swift submodule was updated to a new commit (ba9656fb9762929ca1c1233b8c7b7fefee17f09b).
  • This update resolves a reported issue where boolean types were incorrectly parsed as integers.
  • The change was triggered by testing with WalletConnect x Tron, where the parsing bug was identified.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the reown-swift submodule to a new commit. The purpose of this update, as stated in the pull request description, is to fix a bug where boolean values were incorrectly parsed as integers. This is a straightforward dependency update and appears correct based on the information provided.

@gemcoder21 gemcoder21 merged commit 8cdaac0 into main Feb 20, 2026
1 check passed
@gemcoder21 gemcoder21 deleted the reown-bool-parse branch February 20, 2026 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants