Inline price details into ChartScene market values section

[DRadmir]

Remove the separate AssetPriceDetailsView and show all market data directly in ChartScene's marketValues section. This simplifies navigation by removing the "More" button and extra scene.

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the display of market data within the application by removing a dedicated asset price details screen. The changes aim to simplify the user interface and improve the user experience by presenting all relevant market information directly within the ChartScene. This consolidation eliminates unnecessary navigation and provides a more immediate and comprehensive overview of asset details.

Highlights

• Consolidated Market Data Display: The separate AssetPriceDetailsView has been removed, and its functionality integrated directly into the ChartScene, providing a unified view for market data.
• Streamlined User Experience: The 'More' button and the navigation to a separate screen for market details have been eliminated, simplifying the user flow and reducing navigation steps.
• Enhanced Market Value Presentation: The ChartScene now directly displays a more comprehensive set of market data points, including trading volume, FDV, max supply, all-time high, and all-time low, without requiring a separate view.
• Updated UI Component Usage: ListItemView in ChartScene now supports additional titleExtra, subtitleExtra, and infoAction parameters to present detailed information directly within the list items, facilitating the inline display of market data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Features/MarketInsight/Sources/Scenes/ChartScene.swift
  • Imported the InfoSheet module to support inline information sheets.
  • Updated ListItemView instantiation to pass new parameters (titleExtra, subtitleExtra, infoAction) for richer inline data display.
  • Removed the NavigationCustomLink that previously led to the AssetPriceDetailsView.
  • Replaced the sheet modifier for isPresentingMarkets with isPresentingInfoSheet to handle InfoSheetScene presentations.
• Features/MarketInsight/Sources/ViewModels/AssetDetailsInfoViewModel.swift
  • Expanded the marketValues computed property to include additional market data points such as tradingVolume, fdv, maxSupply, allTimeHigh, and allTimeLow.
• Features/MarketInsight/Sources/ViewModels/AssetPriceDetailsViewModel.swift
  • Removed the AssetPriceDetailsViewModel file, as its responsibilities were absorbed by other components for inline display.
• Features/MarketInsight/Sources/ViewModels/ChartSceneViewModel.swift
  • Imported the InfoSheet module.
  • Removed the isPresentingMarkets property, which was used for navigating to the separate price details view.
  • Added an isPresentingInfoSheet property of type InfoSheetType? to manage the presentation of inline info sheets.
  • Removed the onSelectPriceDetails() function, as the separate navigation is no longer needed.
• Features/MarketInsight/Sources/Views/AssetPriceDetailsView.swift
  • Removed the AssetPriceDetailsView file, as its UI content is now integrated directly into the ChartScene.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the chart scene to inline asset price details, removing the need for a separate "More" details screen. This is achieved by removing AssetPriceDetailsView and its view model, and consolidating all market data into AssetDetailsInfoViewModel. The changes simplify the navigation and UI flow as described in the pull request. The implementation is clean, consistent, and correctly removes unused code and properties. The new logic appears robust and handles cases like missing market data correctly. Overall, this is a great simplification and improvement to the codebase.