Skip to content

Update Rust workspace resolver and rustfmt#992

Merged
gemcoder21 merged 1 commit intomainfrom
rustfmt-config
Mar 6, 2026
Merged

Update Rust workspace resolver and rustfmt#992
gemcoder21 merged 1 commit intomainfrom
rustfmt-config

Conversation

@0xh3rman
Copy link
Collaborator

@0xh3rman 0xh3rman commented Mar 6, 2026

  • Bump Cargo workspace resolver to 3 and align formatting settings: add style_edition = "2024"
  • Update skills/code-style.md to reflect the new 180-character line length.

Bump Cargo workspace resolver to 3 and align formatting settings: add style_edition = "2024" and increase max_width to 180 in rustfmt.toml. Update skills/code-style.md to reflect the new 180-character line length. These changes ensure the project uses the newer Cargo resolver behavior and consistent rustfmt configuration.
@semanticdiff-com
Copy link

Review changes with  SemanticDiff

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's Rust tooling configurations. It updates the Cargo workspace resolver to its latest version and aligns the rustfmt settings with the 2024 edition, including an increased maximum line width. Additionally, the project's code style documentation has been revised to reflect these new formatting standards, ensuring consistency across the codebase.

Highlights

  • Cargo Workspace Resolver: The Cargo workspace resolver has been updated from version 2 to 3 in Cargo.toml.
  • Rustfmt Configuration: The rustfmt.toml configuration now includes style_edition = "2024" to align with the latest formatting standards.
  • Code Style Documentation: The skills/code-style.md document has been updated to reflect the new maximum line length of 180 characters, consistent with the rustfmt.toml configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Cargo.toml
    • Updated the workspace resolver from version 2 to 3.
  • rustfmt.toml
    • Added the style_edition = "2024" setting.
    • Maintained the max_width at 180 and reorder_imports as true.
  • skills/code-style.md
    • Updated the documented line length from 160 to 180 characters.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the Cargo workspace resolver to version 3 and aligns the rustfmt.toml configuration by adding style_edition = "2024". Additionally, the skills/code-style.md documentation has been updated to reflect the new 180-character line length, ensuring consistency across the project's formatting guidelines. The changes are straightforward and correctly implement the described updates.

Note: Security Review has been skipped due to the limited scope of the PR.

@gemcoder21 gemcoder21 merged commit c8a48d0 into main Mar 6, 2026
4 checks passed
@gemcoder21 gemcoder21 deleted the rustfmt-config branch March 6, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants