Conversation
0xh3rman
commented
Feb 19, 2026
- Extend OKX DEX integration to support EVM chains (Manta/Mantle) alongside Solana.
- Add EVM constants (chain index map and native token sentinel), new helper utilities (chainIndex, isEvmChain, dexIds) and update asset/address resolution and referral handling per chain.
- Refactor buildSwapParams/get_quote/get_quote_data to pass chain context and split quote-data construction into EVM (hex calldata, gas, optional approval) and Solana (base58->base64 serialization, compute unit estimation) flows.
- Add test fixtures and mocks for Manta (MANTA_USDC_ADDRESS, test wallet, createOkxEvmQuoteRequest) and expand unit/integration tests to cover EVM native/token swaps, approval behavior, and parameter propagation.
Extend OKX integration to support EVM chains (Manta) alongside Solana. Add EVM constants (chain index map and native token sentinel), new helper utilities (chainIndex, isEvmChain, dexIds) and update asset/address resolution and referral handling per chain. Refactor buildSwapParams/get_quote/get_quote_data to pass chain context and split quote-data construction into EVM (hex calldata, gas, optional approval) and Solana (base58->base64 serialization, compute unit estimation) flows. Add test fixtures and mocks for Manta (MANTA_USDC_ADDRESS, test wallet, createOkxEvmQuoteRequest) and expand unit/integration tests to cover EVM native/token swaps, approval behavior, and parameter propagation.
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the OKX DEX integration by extending its functionality beyond Solana to include EVM-compatible chains such as Manta, Mantle, and XLayer. The changes involve introducing chain-specific logic for asset resolution, referral handling, and quote data processing, ensuring that the swapper can seamlessly interact with both Solana and EVM ecosystems through the OKX provider. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully extends the OKX DEX integration to support EVM chains like Manta and Mantle, alongside the existing Solana support. The changes introduce new constants for EVM chains, helper utilities for chain identification and token address resolution, and refactor the quote and swap data building processes to be chain-aware. The addition of comprehensive unit and integration tests for EVM native and token swaps, including approval behavior, ensures the new functionality is robust. The code is well-structured and demonstrates a clear separation of concerns between Solana and EVM logic.