feat(framework): drive the domain preset loop as the review phase (#252)#262
Merged
Conversation
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252. Part of #204 (Open Loop). Implements the direction Rom agreed on the issue: presets own the review loop, keep architect/build/deploy as the spine.
When a run has a domain preset, its loop now REPLACES the built-in production-grade checklist. Each checklist pass dispatches a
major-changeevent through the preset driver-backed loop, so its review chain (code review, test coverage, security review) fires through the wrapped agent, and Bootstrap pass/improve/maxPasses gates on the union of the{ blockers }verdicts. A preset with no loop for the build event falls back to the built-in checklist, so a run is never left unreviewed.domainLoopChecklist(loop, {kind?, fallback?})+verdictFromLoopRunin steps.ts.{ blockers }verdict so the loop actually gates.Verified:
--fake --preset software-development): the review chain drives the checklist, flags "No authentication...", improve runs, pass 2 clears -> production-grade, no crash.Typecheck + framework 118 + ai-autopilot 316 tests green. Changeset minor (both packages).
Follow-up (separate): a
bug-fixevent path, and letting a preset choose the build event kind.