refactor: drop dead code in the driver and runner adapters#238
Merged
Conversation
- claude-code driver: remove the lastSessionId field that was written but never read (the id reaches the UI via the emitted result event). - docker runner: drop an unreachable '?? ""' on a trimmed string. - webcontainer runner: the timeout race value is discarded by the timedOut branch; resolve the same 124 it returns instead of a stray 137. Closes #234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small dead-code cleanups from the review, no behavior change:
lastSessionIdfield (written, never read).?? ''on a trimmed string.Both packages build and test green. No changeset (internal only).
Closes #234