feat(framework): move the page builder off the preset onto its skill (#207)#208
Merged
Conversation
A framework was represented twice: its page-builder persona rode the preset seam while its docs rode the skill seam. This finishes the framework=skill design: a Skill now carries its curated framing personas alongside the doc pointer, so a framework's whole knowledge is one unit. vikeSkill carries vikePageBuilder; new nextSkill carries nextPageBuilder. A preset is now a pure detector pointing at its framework skill, and run.ts frames the page builder through the skill set (the selected preset's skill is always framed, so an empty from-scratch project still gets the flagship page builder). New exports: nextSkill, skillPersonas. Part of #190.
suleimansh
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207. Follow-up to #190.
A framework was represented twice: its page-builder persona rode the preset seam (framed as the run's base), while only its docs rode the skill seam. This finishes the "framework = skill, no adapter axis" design.
What changed
Skillnow carries curated framingpersonasalongside itsllms.txtpointer, so a framework's whole knowledge is one unit.vikeSkillcarriesvikePageBuilder; newnextSkillcarriesnextPageBuilder.skill(vikePreset.skill = vikeSkill). Built-in presets no longer embed page-builder personas.run.tsframes the page builder through the skill set, notpreset.personas. The selected preset's skill is always framed, so an empty from-scratch project still gets the flagship (Vike) page builder as the fallback.nextSkill,skillPersonas.presetPersonasand the framing narration are unchanged.Checks
skillPersonasdedup, page-builder-via-skill framing, and the empty-project fallback.framework --fakestill narratesDetected Vike (confidence 2); framing with 3 persona(s), 1 skill(s).