chore: export rbac/crud/shell composers symmetrically + refresh compose comments#199
Merged
Merged
Conversation
…se comments vikeAuthComposer and vikeDataModeler were re-exported individually from both barrels, but their peers vikeRbacComposer/vikeCrudComposer/vikeShellComposer were only reachable via the vikeExtensionPersonas array. Export the three for symmetry so a consumer can cherry-pick any built-in extension composer. Also refresh two stale comments in run.ts that still described the compose set as vike-auth only; it now frames data, auth, rbac, crud, and themes/layouts. Closes #198
suleimansh
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass-3 hygiene over the compose-personas work. Typecheck + tests green (ai-autopilot 265, framework 57).
Dead-code scan: clean
No unused exports, no unreferenced personas/presets, no orphaned test helpers. Every export resolves to a real consumer (examples/tests/presets). The
vike-*packages are stillprivate/0.0.0and absent from npm, so the "resolves only inside the vike-data workspace" persona notes are accurate and were left untouched.What changed
vikeRbacComposer/vikeCrudComposer/vikeShellComposerare now re-exported individually frompersonas/index.tsand the package root, matchingvikeAuthComposer/vikeDataModeler. They were previously reachable only through thevikeExtensionPersonasarray. New public exports, so this ships a minor changeset.framework/src/run.ts(thecomposeExtensionsJSDoc and an inline note) still described the compose set as "vike-auth only"; refreshed to name the full set (data, auth, rbac, crud, themes/layouts).Closes #198