refactor: dedup neutral guardrail persona + flatten run.ts wiring#197
Merged
Conversation
Name the path-neutral guardrail tail once (neutralGuardrails) and spread it into both sharedPersonas and vikeExtensionPersonas so the invariant is structural, not maintained by copy. In run.ts, hoist the duplicated verifyWorkspace option and flatten the deploy step's double-nested ternary that tested opts.deploy twice. No behavior change. Closes #196
suleimansh
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal quality pass over the compose-personas code. No behavior change; typecheck + tests green (ai-autopilot 265, framework 57).
What
uiIntentDesignerwas hand-listed in bothsharedPersonasandvikeExtensionPersonas. Named the path-neutral tail once (neutralGuardrails) and spread it into both. Emitted persona order is byte-identical; the "neutral guardrails apply on every path" invariant is now structural instead of copy-maintained.verifyWorkspace ? { verifyWorkspace: true } : {}(used by the build and improve steps) into one const, and flattened the deploy step's double-nested ternary that testedopts.deploytwice into a single top-level branch.No user-facing surface changed, so no changeset.
Closes #196