Open
Conversation
Also change the test to not use the TMPPATH env var at all since the path is renormalized on Windows and doesn't exactly match the expected value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating #14, I found that the tests couldn't be run on Windows:
npm testfailed with this output:This PR uses cross-env to fix that.
npm testfailed with output like this:This appears to be an issue with Jest with ESM on Windows that has been fixed in newer Jest versions, so I updated Jest and most dev dependencies to fix that.
C:\Usersinto/c/Users) or because of assumptions that process pids are strictly monotonically increasing or that the user has "EDITOR" and "TMPDIR" env variables set, so I fixed the tests to not depend on these things.With these changes, the tests go from not starting at all on Windows to having 49/51 passing (depending on the build of Bash installed).
Full npm test output on Windows