Fix incorrect dictionary cleanup for binary topics (issue #54)#55
Open
deannaspinks wants to merge 1 commit intogeekscape:masterfrom
Open
Fix incorrect dictionary cleanup for binary topics (issue #54)#55deannaspinks wants to merge 1 commit intogeekscape:masterfrom
deannaspinks wants to merge 1 commit intogeekscape:masterfrom
Conversation
Correct remove_message_handler() to delete topics from _message_handlers_binary_topics instead of _message_handlers_wildcard_topics when cleaning up binary non-wildcard handlers. This prevents a KeyError and ensures internal handler tracking dictionaries remain consistent.
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the remove_message_handler() method where binary topics were being deleted from the wrong internal tracking dictionary, causing a KeyError and leaving the system in an inconsistent state.
Changes:
- Corrected the dictionary reference in
remove_message_handler()to delete from_message_handlers_binary_topicsinstead of_message_handlers_wildcard_topicswhen cleaning up binary non-wildcard topic handlers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct remove_message_handler() to delete topics from _message_handlers_binary_topics instead of
_message_handlers_wildcard_topics when cleaning up binary non-wildcard handlers.
This prevents a KeyError and ensures internal handler tracking dictionaries remain consistent.
This resolves issue #54