Set default value for the 'use_create_frame' argument to a data sources' start_stream() method to False, making the use of create_frames() the default#49
Open
rskew wants to merge 1 commit intogeekscape:masterfrom
Conversation
…es' start_stream() method to False, making the use of create_frames() the default
Owner
|
There has been a long outstanding need to generally provide an out-of-the-box means of terminating Agents(Pipelines) processes in circumstances other than only CI tests …
My preference is that the PR#49 suggestion shouldn’t conflict with an Agent(Pipeline), which is very long running and is processing lots of Tasks(Streams) each consisting of a single File(Frame) and not having the unnecessary overhead of starting and stopping a background thread for every Task(Stream) in that case. This use-case was the original motivation for the |
Contributor
Author
|
Thanks @geekscape , sounds like I'll leave it with you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: For writing tests, its useful to have the stream stop once the frames have been processed, so the test code doesn't have to manually stop the stream.
When a data source uses
create_frames()this happens nicely, ascreate_frames()stops the stream once all frames have been generated.However, when we have a test that processes a single file, the default of
use_create_frame=TruecausesDataSchemeFileto callcreate_frame()and then not stop the stream.