Open
Conversation
This was referenced Jan 21, 2025
rskew
force-pushed
the
rs/notify-stream-creater-of-stream-stop
branch
from
160121f to
5d87b88
Compare
rskew
force-pushed
the
rs/notify-stream-creater-of-stream-stop
branch
2 times, most recently
from
1ebe042 to
e4e807d
Compare
rskew
force-pushed
the
rs/notify-stream-creater-of-stream-stop
branch
from
e4e807d to
e99a7b6
Compare
rskew
commented
Jun 30, 2025
| element_name, stream, stream_event, diagnostic, | ||
| in_destroy_stream=True)) | ||
| if stream.state == StreamState.ERROR: | ||
| break |
Contributor
Author
There was a problem hiding this comment.
This break prevents stop_stream being called on downstream elements if an upstream stop_stream raises
rskew
commented
Jun 30, 2025
| break | ||
| destroy_stream_state = StreamState.ERROR | ||
| elif destroy_stream_state == StreamState.ERROR: | ||
| stream.state = StreamState.ERROR |
Contributor
Author
There was a problem hiding this comment.
Feed the error state back into the next stop_stream call, so that element knows the stream has stopped in error and can cleanup/finalise appropriately
rskew
commented
Jun 30, 2025
rskew
commented
Jun 30, 2025
| stream.lock.release() | ||
| self.destroy_stream(get_stream_id(), use_thread_local=False) | ||
| stream.state = StreamState.ERROR | ||
| self.destroy_stream(get_stream_id(), use_thread_local=False, diagnostic=diagnostic) |
Contributor
Author
There was a problem hiding this comment.
Passing diagnostic here allows the stop-stream message put on the response_queueindestroy_streamto include the diagnostic message fromstart_stream`
PipelineImpl posts to the listening response_queue and/or response_topic when the stream is destroyed. A stream creator might pass a queue_response or topic response when calling create_stream(), so it can be notified as frames are processed. If a stream exits due to an error in process_frame then these listeners will be notified, but if the stream exits without error then the listeners will not previously be notified.
rskew
force-pushed
the
rs/notify-stream-creater-of-stream-stop
branch
from
e99a7b6 to
a64da07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stream creator might pass a queue_response or topic response when calling create_stream(), so it can be notified as frames are processed.
If a stream exits in error, the stream creator will be notified, but if the stream exits without error, the stream creator has no way of knowing that the stream has ended.
This change posts to the queue and/or topic when the stream is destroyed with no error condition.
Implements #38