Handle graph-definition syntax for edges#27
Open
rskew wants to merge 3 commits intogeekscape:masterfrom
Open
Conversation
rskew
force-pushed
the
rs/edge-definitions
branch
3 times, most recently
from
9d9c20e to
3b15f3d
Compare
rskew
force-pushed
the
rs/edge-definitions
branch
from
3b15f3d to
a9df6e8
Compare
rskew
force-pushed
the
rs/edge-definitions
branch
from
a9df6e8 to
4a0f6d5
Compare
rskew
force-pushed
the
rs/edge-definitions
branch
from
4a0f6d5 to
43a282a
Compare
Example graph:
__________
/ \ \
A B ---- C --->
\___/______/
has syntax in a pipeline definition:
"graph": [
"(A B (A.a_out_1: b_in_1 A.a_out_2: b_in_2) C (A.a_out_1: c_in_1 B.b_out_1: c_in_2 A.a_out_2: c_in_3))"
],
Note that output names must be fully-qualified, e.g. "B.b_out_1" instead
of "b_out_1". This is due to the graph traversal not yet handling edges
defined between B and C in the example graph, only between A and B, and
between A and C.
rskew
force-pushed
the
rs/edge-definitions
branch
from
43a282a to
0a7aae8
Compare
…class name. Update element_name to match the 'name' field of an element in the pipeline definition rather than the class name
rskew
force-pushed
the
rs/edge-definitions
branch
from
0a7aae8 to
8376c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable optional specification of edges between pipeline-element outputs and pipeline-element inputs.
Removing this
breakin the existing test causes it to fail, the other changes in this PR make the test pass: https://github.com/geekscape/aiko_services/blob/master/src/aiko_services/tests/unit/test_pipeline_graph.py#L115Example graph:
has pipeline definition graph syntax:
Note that output names (if specified) must be fully-qualified, e.g. "B.b_out_1" instead
of "b_out_1". This is due to the graph traversal not yet handling edges
defined between B and C in the example graph, only between A and B, and
between A and C.
If edges are not specified, input names are drawn from the swag as normal.
Use of
map_out_nodesin_process_map_outandmap_in_nodesin_process_map_inare commented out because of this issue with the traversal. Rather than completely change the structure ofmap_in_nodesandmap_out_nodes, I've left them and added a new structureedge_definitions, with the aim of making this easier to review.