Skip to content

remove hard constraint on context arg in Frankenstein class#24

Open
pdmct wants to merge 1 commit intogeekscape:masterfrom
pdmct:remove-context-arg-dependency
Open

remove hard constraint on context arg in Frankenstein class#24
pdmct wants to merge 1 commit intogeekscape:masterfrom
pdmct:remove-context-arg-dependency

Conversation

@pdmct
Copy link
Contributor

@pdmct pdmct commented Nov 11, 2024

This removes the hard constraint on the Frankenstein class.
It checks for the presence of "context" before using it to get the implementations, thus allowing a component to be created without the context (if so desired).

This is necessary to get some experiments with basilisp working among other things (and shouldn't affect any existing functionality), as the context is required to be a positional arg in the constructor to avoid name munging difficulties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant